Hi Julian,

I have just used your patch (with a little modification:
PKG_CHECK_MODULES(XML2, libxml-2.0, ,)instead of
PKG_CHECK_MODULES(XML2, xml-2.0, ,) which was not working)
and regenerated the package files. It seems now to build fine.
So, here is the new patch.

If I have missed something, please just let me know.
Thanks.

-- 
Emmanuel Thomas-Maurin <manutm...@gmail.com>

Description: correct the determination of buildflags
 libraries must go into the LDADD variable to build correctly
 with ld --as-needed.
 To do this the flags must be determined in configure.ac via
 the pkg-config macros
Author: Julian Taylor <jtaylor.deb...@googlemail.com>
--- tickr-0.5.3.orig/configure.ac
+++ tickr-0.5.3/configure.ac
@@ -28,6 +28,9 @@ AC_FUNC_MALLOC
 AC_FUNC_REALLOC
 AC_CHECK_FUNCS([memset select socket strerror strncasecmp strtoul])
 
+PKG_CHECK_MODULES(GTK2, gtk+-2.0, ,)
+PKG_CHECK_MODULES(XML2, xml-2.0, ,)
+
 AC_CONFIG_FILES([Makefile
                  src/Makefile
                  src/tickr/Makefile
--- tickr-0.5.3.orig/src/tickr/Makefile.am
+++ tickr-0.5.3/src/tickr/Makefile.am
@@ -24,11 +24,11 @@ tickr_SOURCES = news_main.c\
 	news_connectwin.c
 
 tickr_CFLAGS = -O2 -Wall -Wextra -Wunused-parameter -Wshadow -Wpointer-arith -ffast-math\
-	-pedantic `pkg-config --cflags gtk+-2.0` `xml2-config --cflags`
+	-pedantic $(GTK2_CFLAGS) $(XML2_CFLAGS)
 
-tickr_LDFLAGS = ../libetm-0.4/libetm.a `pkg-config --libs gtk+-2.0` `xml2-config --libs`
+tickr_LDFLAGS = ../libetm-0.4/libetm.a
 
-tickr_LDADD = ../libetm-0.4/libetm.a
+tickr_LDADD = ../libetm-0.4/libetm.a $(GTK2_LIBS) $(XML2_LIBS)
 
 tickr_DATA = ../../images/tickr-icon.png ../../images/tickr-logo.png\
 	../../images/tickr-rss-icon.png ../../images/tickr-icon.xpm

Reply via email to