Package: e2fsprogs
Version: 1.41.12-4stable1
Severity: normal
File: /sbin/badblocks
Tags: patch

In read-only testing with a pattern badblocks ignores the -s flag.

Patch:

--- badblocks.c.orig    2011-06-18 13:14:54.000000000 -0400
+++ badblocks.c 2011-10-25 16:50:08.580565884 -0400
@@ -480,8 +480,9 @@
        num_blocks = last_block - 1;
        if (!t_flag && (s_flag || v_flag)) {
                fputs(_("Checking for bad blocks (read-only test): "), stderr);
-               if (v_flag <= 1)
-                       alarm_intr(SIGALRM);
+       }
+       if (s_flag && v_flag <= 1) {
+               alarm_intr(SIGALRM);
        }
        while (currently_testing < last_block)
        {


Minor side bug:

In read only testing with a pattern it says "Testing with pattern 0x00" which
is the same words it uses when doing a write test.

Patch to make it say "Read Testing with pattern 0x00":

--- badblocks.c.orig    2011-06-18 13:14:54.000000000 -0400
+++ badblocks.c 2011-10-25 16:59:43.067604943 -0400
@@ -471,6 +471,9 @@
        }
        if (t_flag) {
                fputs(_("Checking for bad blocks in read-only mode\n"), stderr);
+                if (s_flag | v_flag) {
+                       fputs(_("Read "), stderr);
+                }
                pattern_fill(blkbuf + blocks_at_once * block_size,
                             t_patts[0], block_size);
        }

-- System Information:
Debian Release: 6.0.3
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.32 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages e2fsprogs depends on:
ii  e2fslibs                1.41.12-4stable1 ext2/ext3/ext4 file system librari
ii  libblkid1               2.17.2-9         block device id library
ii  libc6                   2.13-10          Embedded GNU C Library: Shared lib
ii  libcomerr2              1.41.12-4stable1 common error description library
ii  libss2                  1.41.12-4stable1 command-line interface parsing lib
ii  libuuid1                2.17.2-9         Universally Unique ID library
ii  util-linux              2.17.2-9         Miscellaneous system utilities

e2fsprogs recommends no packages.

Versions of packages e2fsprogs suggests:
pn  e2fsck-static                 <none>     (no description available)
pn  gpart                         <none>     (no description available)
ii  parted                        2.3-5      The GNU Parted disk partition resi

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to