This confuses me atleast. In my testing, up works fine, like it should. But ifdown of eth0 turns eth0 off cause if the set link down. The same with eth0:x, cause set link down/up doesn't support labels.
If set link down was removed, it would work as expected, but I don't think overall that is what is wanted. Bob Proulx <b...@proulx.com> wrote: Patrick Domack wrote: > Just adding the label is not enough. It will fix ifup, but ifdown is > still horribly broken. Adding the label to both ifup and ifdown symmetrically should be enough. As you propose in your patch. > ifdown still downs the whole interface do to the ip link set dev x > down line, it shouldn't be called on alias interfaces, but that is > beyond me at the moment. Also not sure if the tun up/down could use > this code also. The debian/testbuild file needs to be modified to > pass for these modifications Earlier I wrote: >> I believe that you should always be able to add a label to the >> interface when doing 'ip addr add'. And that when deleting the >> interface with 'ip addr del' it should always be okay (but not >> required) to use the same option arguments used as when it was added. >> If a label is provided then it must match. I wrote that poorly and confusingly. Seeing Patrick's message makes that clear. Sorry. I meant that you can down an interface without a label. If the label is provided it must match. But labels will be required on both due to the problem Patrick points out. Downing an interface without the label will down the entire interface. Therefore for any interface brought up with a label it should also be brought down with the same label to restrict the action. Bob
