Source: postler
Version: 0.1.1-1
Severity: seriouos
Justification: fails to build from source
Tags: patch
Hi,
postler FTBFS on armel, armhf, alpha and sh4.
https://buildd.debian.org/status/fetch.php?pkg=postler&arch=armel&ver=0.1.1-1&stamp=1319178797
http://buildd.debian-ports.org/status/package.php?p=postler&suite=sid
-----
Checking for program intltool-merge : /usr/bin/intltool-merge
Checking for header locale.h : yes
Checking for gio-2.0 >= 2.26.0 : yes
Checking for unique-1.0 >= 0.9 : yes
Checking for gtk+-2.0 >= 2.18.0 : yes
Checking for webkit-1.0 >= 1.1.18 : yes
Checking for libnotify >= : yes
Checking for libcanberra >= : yes
Checking for indicate-0.5 >= : yes
Checking for header sys/filio.h : not found
Checking for function vasprintf : no
/build/buildd-postler_0.1.1-1-armel-g8g2HG/postler-0.1.1/wscript:137:
error: the configuration failed (see
'/build/buildd-postler_0.1.1-1-armel-g8g2HG/postler-0.1.1/_build_/config.log')
make[1]: *** [override_dh_auto_configure] Error 1
make[1]: Leaving directory
`/build/buildd-postler_0.1.1-1-armel-g8g2HG/postler-0.1.1'
make: *** [build] Error 2
-----
It is because this is wrong in the check of vasprintf.
The 3rd argument of vasprintf is not pointer of char but va_list.
-----
$ cat wscript
......
131 # isync
132 conf.check (header_name='sys/filio.h')
133 conf.check (fragment='#define _GNU_SOURCE\n#include <stdio.h>\n' \
134 'int main(char** argv, int argc)\n' \
135 '{ char* a;\nvasprintf(&a, "%s", ""); return 0; }', \
136 define_name='HAVE_VASPRINTF', msg='Checking for function
vasprintf', \
137 mandatory=True)
138 check_function ('socket', 'sys/socket.h')
139 if conf.env['DEST_OS'] == 'freebsd':
-----
I made patch to fix this problem. Could you check and apply this patch?
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
diff --git a/wscript b/wscript
index db8dbba..4af9bc6 100644
--- a/wscript
+++ b/wscript
@@ -132,7 +132,7 @@ def configure (conf):
conf.check (header_name='sys/filio.h')
conf.check (fragment='#define _GNU_SOURCE\n#include <stdio.h>\n' \
'int main(char** argv, int argc)\n' \
- '{ char* a;\nvasprintf(&a, "%s", ""); return 0; }', \
+ '{ char* a;\nva_list ap\nvasprintf(&a, "%s", ap); return 0; }', \
define_name='HAVE_VASPRINTF', msg='Checking for function vasprintf', \
mandatory=True)
check_function ('socket', 'sys/socket.h')
