Package: git-buildpackage Version: 0.5.32 Severity: important gbp-pq command contains the following code: if in_patch: if line.startswith('-- '): # Found final signature, we're done: tmp.write(line) break
The assumption written in the comment is incorrect. '-- ' can be a part of a valid patch, e.g.: -- original text +- patched text In such a case the above code incorrectly truncates the file it generates. For a real-life example please do the following: gbp-clone git://anonscm.debian.org/users/robert/manpages-pl.git cd manpages-pl gbp-pq import gbp-pq export quilt push -a # this fails (Also note that gpp-pq renames `file.patch' into `file.patch.patch'. I belive it could work smarter, but it's another issue, quite a minor one). Regards, robert -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (990, 'unstable'), (200, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.38-2-686 (SMP w/1 CPU core) Locale: LANG=pl_PL, LC_CTYPE=pl_PL (charmap=ISO-8859-2) Shell: /bin/sh linked to /bin/dash Versions of packages git-buildpackage depends on: ii devscripts 2.11.1 ii git [git-core] 1:1.7.7-2 ii git-core 1:1.7.7-2 ii python 2.7.2-9 ii python-dateutil 1.5-1 ii python2.6 2.6.7-4 ii python2.7 2.7.2-6 Versions of packages git-buildpackage recommends: ii cowbuilder 0.65 ii pristine-tar 1.15 Versions of packages git-buildpackage suggests: ii python-notify 0.1.1-3 ii unzip 6.0-5 -- Configuration Files: /etc/git-buildpackage/gbp.conf changed [not included] -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org