Source: grdesktop
Version: 0.23+d040330-2
Severity: normal
User: [email protected]
Usertags: hardening-format-security hardening

the package grdesktop fails to compile with the new hardened compiler
flags dpkg-buildflag outputs [0].
The problematic flag is: -Werror=format-security
See the ubuntu buildlog:
https://launchpadlibrarian.net/83137933/buildlog_ubuntu-precise-i386.grads_2.0.a9-2_FAILEDTOBUILD.txt.gz
Snippet:
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -I../intl -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/pango-1.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -DORBIT2=1 -pthread -D_REENTRANT
-I/usr/include/gtk-2.0 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/pango-1.0 -I/usr/include/gail-1.0
-I/usr/include/freetype2 -I/usr/include/atk-1.0
-I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12 -I/usr/include/libgnomeui-2.0
-I/usr/include/libart-2.0 -I/usr/include/gconf/2
-I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0
-I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/orbit-2.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
-I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
-I/usr/include/cairo -I/usr/include/gio-unix-2.0/
-DDATADIR=\""/usr/share"\" -DLOCALEDIR=\""/usr/share/locale"\"
-DKBPATH=\""/usr/share/rdesktop/keymaps/"\"  -D_FORTIFY_SOURCE=2  -g -O2
-fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -c `test -f 'run.c' || echo './'`run.c
run.c: In function 'run_rdesktop':
run.c:113:3: error: format not a string literal and no format arguments
[-Werror=format-security]
cc1: some warnings being treated as errors



The buildflags are not exported in debian, but can be enabled e.g. by
adding this to debian/rules:

 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk

Please fix the issues and maybe also enable the hardened build in debian.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html




Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to