tags 646073 + patch
quit

Hi James,

James McCoy wrote:

> #643632 moved -D_FORTIFY_SOURCE from CFLAGS to CPPFLAGS, but the man page
> wasn't updated.

Hm, a shame you didn't attach a patch. :)  Let's fix that...

-- >8 --
Subject: dpkg-buildflags(1): -D_FORTIFY_SOURCE=2 goes in CPPFLAGS

In 1.16.1.1~8 (2011-10-02), dpkg-buildflags learned to set
-D_FORTIFY_SOURCE=2 in CPPFLAGS instead of CFLAGS and CXXFLAGS but the
documentation wasn't updated to match.

Reported-by: James Vega <james...@debian.org>
Signed-off-by: Jonathan Nieder <jrnie...@gmail.com>
Closes: #646073
---
 debian/changelog      |    8 ++++++++
 man/dpkg-buildflags.1 |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 7ef29f9b..0a89409f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+dpkg (1.16.1.2) UNRELEASED; urgency=low
+
+  * Update dpkg-buildflags(1) to note that the processor option
+    -D_FORTIFY_SOURCE=2 is set in CPPFLAGS now instead of CFLAGS and
+    CXXFLAGS. Closes: #646073
+
+ -- Jonathan Nieder <jrnie...@gmail.com>  Thu, 20 Oct 2011 21:55:44 -0500
+
 dpkg (1.16.1.1) UNRELEASED; urgency=low
 
   [ Raphaƫl Hertzog ]
diff --git a/man/dpkg-buildflags.1 b/man/dpkg-buildflags.1
index ba296af8..a018edba 100644
--- a/man/dpkg-buildflags.1
+++ b/man/dpkg-buildflags.1
@@ -200,7 +200,7 @@ input and contains "%n".
 .B fortify
 This setting (enabled by default) adds
 .B \-D_FORTIFY_SOURCE=2
-to \fBCFLAGS\fP and \fBCXXFLAGS\fP. During code generation the compiler
+to \fBCPPFLAGS\fP. During code generation the compiler
 knows a great deal of information about buffer sizes (where possible), and
 attempts to replace insecure unlimited length buffer function calls with
 length-limited ones. This is especially useful for old, crufty code.
-- 
1.7.7




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to