Package: git-daemon-run Version: 1:1.7.6.3-1 Severity: normal Dear Maintainer, sometimes an incoming connection the the git-daemon will abort in such a way that the daemon doesn't notice and keeps the connection open.
When git is upgraded the daemon will be killed and restarted. When it tries to bind to the address to listen to it will fail because there are some open connection still using that address. They will be in TIME_WAIT for a couple minutes after the old daemon is killed. So the daemon starts not listening (or only listening on IPv6). This does not make for a clean upgrade. If git-daemon is started with --reuseaddr, then the fact that there are old connections around will not stop it from binding to the correct address. So --reuseaddr makes a clean upgrade much more likely. In my opinion --reuseaddr should not be an option - it should always be used. This may be debatable. However when a daemon can be restarted automatically it is certain that --reuseaddr will make the restart cleaner. So please consider including --reuseaddr in /etc/sv/git-daemon/run Thanks, NeilBrown -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/bash Versions of packages git-daemon-run depends on: ii adduser 3.113 ii git 1:1.7.6.3-1 ii runit 2.1.1-6.2 git-daemon-run recommends no packages. git-daemon-run suggests no packages. -- Configuration Files: /etc/sv/git-daemon/run changed: exec 2>&1 echo 'git-daemon starting.' exec chpst -ugitdaemon \ "$(git --exec-path)"/git-daemon --reuseaddr --verbose --base-path=/var/cache/git /var/cache/git -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
