Package: olvwm Version: 4.4.3.2p1.4-28 Severity: important Tags: patch Dear Maintainer,
In bug 635154 I reported the exact opposite bug: olvwm corrupts DISPLAY when running menu commands if DISPLAY *lacks* screen number. Someone else reported the same problem in bug 617236 and provided a misguided patch that was unfortunately applied (debian/patches/display_setting). This has merely altered the bug so that the corruption occurs in different circumstances (when DISPLAY *has* a screen number). The patch changed "%.*s" to "%*s", which causes the variable 'len' to be interpreted as a field width (affecting how many spaces are inserted into the output) rather than a precision (controlling how big a prefix of the original DISPLAY to copy), which is nonsense. That dot needs to be restored. The original sprintf line made sense. It appends the specified screen number to a prefix of the original DISPLAY. The prefix is intended to be everything except the screen number. The prefix length is calculated correctly when the original DISPLAY has a screen number (contains a dot), but incorrectly when the original DISPLAY lacks a screen number (lacks a dot). The fix is therefore to correct that calculation: - len = colon - display; + len = strlen(display); Disclaimer: I haven't tested that. I'm not set up to build Debian packages from source. Thanks, AMC -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (900, 'testing'), (800, 'stable'), (600, 'unstable') Architecture: i386 (i686) Kernel: Linux 3.0.0-1-686-pae (SMP w/2 CPU cores) Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/dash Versions of packages olvwm depends on: ii libc6 2.13-21 ii libx11-6 2:1.4.4-1 ii libxext6 2:1.3.0-3 ii libxpm4 1:3.5.9-1 olvwm recommends no packages. Versions of packages olvwm suggests: pn menu 2.1.45 pn olwm <none> pn xview-clients <none> -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
