On 09/26/2011 03:18 PM, Holger Levsen wrote:
tags 640648 + pending
thanks
Hi Scott,
On Dienstag, 6. September 2011, Scott Schaefer wrote:
Attached patch addresses TODO item in sbuject.
applied to feature/640648 branch, will merge into develop once I find time to
test it. Please review the debian/changelog entry I wrote - also it would be
even more awesome if you could include those in future ;)
cheers& thanks,
Holger
_______________________________________________
Piuparts-devel mailing list
piuparts-de...@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/piuparts-devel
Attached is suggested patch to changelog on branch feature/640648
diff --git a/debian/changelog b/debian/changelog
index adea1c5..46a5d17 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,14 +14,12 @@ piuparts (0.42) UNRELEASED; urgency=low
logrotate. Thanks Stefano! (Closes: #638832)
[ Scott Schaefer ]
- * piupartslib/packagesdb.py: rewrite uniqe() function by using the set type
- in place of a list and unique(),and then using set.pop() method in place
- of random.shuffle().
- Also modified the class to no longer pass large "package" objects around,
- but rather to just pass list/set of package names (since I was "forced
to",
- since you cannot add a non-hashable object to a set). This required a new
- function to return package object, given name as input. This required one
- change to piuparts-report and several to piuparts-master. (Closes: 640648)
+ * piupartslib/packagesdb.py: Modify several functions in PackagesDB class
+ to use python 'set' type, instead of a list. This permitted replacing
+ inefficient combination of unique() function and random.shuffle() with
+ python set.pop() method. Since python prohibits storing non-hashable
+ object in a set, minor modifications to piuparts-report and to
+ piuparts-master required. (Closes: 640648)
-- Holger Levsen <hol...@debian.org> Sun, 28 Aug 2011 09:50:12 +0200
