On 22/09/2011 07:36, Steve Langasek wrote: > So my suggestion would be to make the script special-case i386, instead of > adding a runtime dependency on dpkg-dev for dpkg-architecture.
We can use dpkg-architecture and fail back on hard-coded (with or without the handling of i386) if dpkg-architecture is not present. So, this script will remain correct, even if other multiarch dirs are introduced. > However: > >> One subtle departure from Steve's patch here is that if you run >> armv5tel-linux-gnueabi-pkg-config on an i386 system, it will never search >> /usr/lib/pkgconfig - which I think is desirable. If you're missing a >> cross-compiled dependency (zlib, say), it's better that configure fails >> early, rather than trying to link an i386 zlib into an armel binary >> and failing horribly later. > > Keeping /usr/lib/pkgconfig on the path was quite deliberate on my part. > Certainly any library shipping in /usr/lib/pkgconfig is not a multiarch > library, but that doesn't actually mean it has to be a *native* library: it > will be possible to cross-install many -dev packages for a while before it's > possible to co-install them together with the native versions. > > So I do think it's useful to look in /usr/lib/pkgconfig by default even in > the cross-config (and obviously as a last resort, after searching the > architecture-specific directories). In general I think people will find it > easier to simply remove any conflicting native -dev packages from their > build environment than to fiddle with the pkg-config path. For my part, I think this is really error prone. Lots of native libraries will be wrongly detected as present when cross-compiling. Users still have the possibility to overwrite PKG_CONFIG_LIBDIR or to use PKG_CONFIG_PATH. So, let's the user do this if he really wants to include /usr/lib/pkgconfig (this can be documented if required) Regards, Vincent -- Vincent Danjean Adresse: Laboratoire d'Informatique de Grenoble Téléphone: +33 4 76 61 20 11 ENSIMAG - antenne de Montbonnot Fax: +33 4 76 61 20 99 ZIRST 51, avenue Jean Kuntzmann Email: vincent.danj...@imag.fr 38330 Montbonnot Saint Martin -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org