Package: mdm
Version: 0.1.3-2
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

mdm fails to build with a linker that defaults to --as-needed, as shown
in this Ubuntu bug report:

  https://bugs.launchpad.net/ubuntu/+source/mdm/+bug/771082

This is because of incorrect link ordering: it puts libraries before the
objects that use them rather than after.  See:

  http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The following patch fixes this.

  * Fix link order to list libraries after the objects that require them.

--- mdm-0.1.3.orig/Makefile
+++ mdm-0.1.3/Makefile
@@ -24,10 +24,10 @@
 
 mdm-master : library/hazard.o
 mdm-top : library/procfs.o
-mdm-top : override LDFLAGS += -lcurses
+mdm-top : override LDLIBS += -lcurses
 
 mdm-% : programs/mdm-%.c $(LIB)
-       $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $+
+       $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $+ $(LDLIBS)
 
 LIB += library/hazard.o library/procfs.o
 $(LIB) : include/middleman.h

Thanks,

-- 
Colin Watson                                       [cjwat...@ubuntu.com]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to