tags 634112 + patch thanks * Joey Hess <jo...@debian.org>, 2011-07-16, 20:59:
dh_installmanpages is deprecated but not shown by lintian.
Here's a patch.
debian/compress files are deprecated for a while. But only 1 package in the archive has one, and I just filed a bug, so you may not want to bother with that.
I agree that it's not worth effort. (Well, at least my effort. :P) -- Jakub Wilk
diff --git a/checks/debhelper b/checks/debhelper --- a/checks/debhelper +++ b/checks/debhelper @@ -103,6 +103,9 @@ if ($dhcommand eq 'dh_pycentral') { tag 'dh_pycentral-is-obsolete', "line $."; } + if ($dhcommand eq 'dh_installmanpages') { + tag 'dh_installmanpages-is-obsolete', "line $."; + } # Don't warn about recently deprecated commands in code that may be # optional. It may be there only for backports. diff --git a/checks/debhelper.desc b/checks/debhelper.desc --- a/checks/debhelper.desc +++ b/checks/debhelper.desc @@ -109,6 +109,13 @@ Lenny or older system, please ignore this warning. Ref: http://wiki.debian.org/Python/PyCentral2DhPython2 +Tag: dh_installmanpages-is-obsolete +Severity: normal +Certainty: certain +Ref: dh_installmanpages(1) +Info: This package calls dh_installmanpages in its <tt>debian/rules</tt> file. + dh_installmanpages is deprecated in favour of dh_installman. + Tag: dh_desktop-is-deprecated Severity: normal Certainty: certain diff --git a/debian/changelog b/debian/changelog --- a/debian/changelog +++ b/debian/changelog @@ -5,6 +5,7 @@ - boilerplate-copyright-format-uri - comma-separated-files-in-dep5-copyright - debian-copyright-is-symlink + - dh_installmanpages-is-obsolete - missing-field-in-dep5-copyright - missing-license-paragraph-in-dep5-copyright - missing-license-text-in-dep5-copyright @@ -27,6 +28,8 @@ * checks/debhelper: + [NT] Recognise /usr/share/R/debian/r-cran.mk as a cdbs-based build. This prevents false-positive "unneeded cdbs" warning. + + [JW] Check for use of the obsolete dh_installmanpages debhelper + program. Thanks to Joey Hess for the report. (Closes: #634112). * checks/duplicate-files{,.desc}: + [NT] Replace the exception for "__init__.py" files by excluding all empty files from the check. The bug (#632789) only requests diff --git a/t/tests/debhelper-deprecated/debian/debian/rules b/t/tests/debhelper-deprecated/debian/debian/rules --- a/t/tests/debhelper-deprecated/debian/debian/rules +++ b/t/tests/debhelper-deprecated/debian/debian/rules @@ -21,6 +21,7 @@ dh_install dh_installchangelogs dh_installdocs + dh_installmanpages dh_desktop -dh_dhelp dh_scrollkeeper diff --git a/t/tests/debhelper-deprecated/desc b/t/tests/debhelper-deprecated/desc --- a/t/tests/debhelper-deprecated/desc +++ b/t/tests/debhelper-deprecated/desc @@ -5,6 +5,7 @@ Test-For: dh_desktop-is-deprecated dh_dhelp-is-deprecated + dh_installmanpages-is-obsolete dh_pycentral-is-obsolete dh_python-is-obsolete dh_scrollkeeper-is-deprecated diff --git a/t/tests/debhelper-deprecated/tags b/t/tests/debhelper-deprecated/tags --- a/t/tests/debhelper-deprecated/tags +++ b/t/tests/debhelper-deprecated/tags @@ -1,7 +1,8 @@ -W: debhelper-deprecated source: dh_desktop-is-deprecated line 24 -W: debhelper-deprecated source: dh_dhelp-is-deprecated line 25 -W: debhelper-deprecated source: dh_pycentral-is-obsolete line 30 -W: debhelper-deprecated source: dh_python-is-obsolete line 27 -W: debhelper-deprecated source: dh_scrollkeeper-is-deprecated line 26 -W: debhelper-deprecated source: dh_suidregister-is-obsolete line 40 -W: debhelper-deprecated source: dh_undocumented-is-obsolete line 41 +W: debhelper-deprecated source: dh_desktop-is-deprecated line 25 +W: debhelper-deprecated source: dh_dhelp-is-deprecated line 26 +W: debhelper-deprecated source: dh_installmanpages-is-obsolete line 24 +W: debhelper-deprecated source: dh_pycentral-is-obsolete line 31 +W: debhelper-deprecated source: dh_python-is-obsolete line 28 +W: debhelper-deprecated source: dh_scrollkeeper-is-deprecated line 27 +W: debhelper-deprecated source: dh_suidregister-is-obsolete line 41 +W: debhelper-deprecated source: dh_undocumented-is-obsolete line 42