Mark Voorhies wrote:
> When a user arrives at the login page with no "postsignin" in the
> session cookie (e.g., due to having bookmarked the login page)
> the login fails with the message:
> "login failed, perhaps you need to turn on cookies?"
> 
> This is confusing to a user arriving from a bookmark, since cookies
> are likely to be turned on in this case.
> 
> The current behavior is due to commit 9dbbbd (1/7/2008) and _is_
> needed to avoid login failing silently when the user _does_ have
> cookies turned off.
> 
> The best fix may be to make the error message cover both cases, e.g.:
> "login failed, perhaps you need to turn on cookies?  If you are attempting to 
> login from a bookmark, try clicking on the edit link on the page that you 
> want to edit."

I have been considering for a long time making do=postsignin redirect to
the *actual* page. That would avoid exposing such an url, but it does
mean ikiwiki.cgi would be run an additional time at signin which is more
load on the server and slower for the client. Which is sorta why I've
not done it yet, but this additional work is likely not very
significant.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature

Reply via email to