Hi,
>>>>> On Thu, 18 Aug 2011 22:23:33 +0200
>>>>> Stefan Gehn <ste...@gkrellm.srcbox.net> said:
stefan> I don't know much about BSD support in GKrellM but one part of the patch
stefan> looks odd to me:
stefan> --- gkrellm-2.3.5.orig/src/sysdeps/freebsd.c
stefan> +++ gkrellm-2.3.5/src/sysdeps/freebsd.c
stefan> @@ -1395,7 +1399,8 @@ static VoltDefault voltdefault0[] =
stefan> };
stefan> #include <dirent.h>
stefan> -#include <machine/cpufunc.h>
stefan> +/*#include <machine/cpufunc.h>*/
stefan> +#include <sys/io.h>
stefan> #if __FreeBSD_version >= 500042
stefan> #include <dev/smbus/smb.h>
stefan> #elif __FreeBSD_version >= 300000
stefan> Why is the cpufunc.h include commented out? Is it needed for other
stefan> systems and if not why not remove the include altogether?
Indeed. FreeBSD requires cpufunc.h. Further, FreeBSD doesn't have
sys/io.h.
In addition, the following chunk adds inclusion of the include files
blindly which are not required for FreeBSD. It is a system dependent
file for FreeBSD, at least.
--- gkrellm-2.3.5.orig/src/sysdeps/freebsd.c
+++ gkrellm-2.3.5/src/sysdeps/freebsd.c
@@ -36,6 +36,10 @@
#include <sys/param.h>
#include <sys/sysctl.h>
#include <osreldate.h>
+#include <netinet/in.h>
+#include <sys/socketvar.h>
+#include <netinet/in_pcb.h>
+#include <devstat.h>
#if __FreeBSD_version < 500000
#include <kvm.h>
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
u...@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
