severity 617896 minor
thanks

* Holger Levsen <hol...@layer-acht.org> [2011-03-12 10:10:14 CET]:
> Package: gitolite
> Version: 1.5.7-2
> Severity: important
> User: debian...@lists.debian.org
> Usertags: piuparts piuparts.d.o
> 
> during a test with piuparts I noticed your package left unowned files on the 
> system after purge, which is a violation of policy 6.8:
> 
> http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

 policy 6.8 is about how the maintainer scripts are called and what
happens at errors, it doesn't describe what remove/purge actually has to
do.  It is about the technical details with respect to what dpkg is
doing and what the status of the package during the process is.  And it
explictly states in put 2: "The *package's* files are removed (except
`conffile's)."  Emphasis added, user data isn't package's files.

 Interestingly, I can't find anything about remove/purge in the policy
besides of what dpkg does ...  I'm not saying that it shouldn't be tried
to clean up properly, it though is left open to cover expectations.  And
personally, git repositories with user data is something that I would
highly consider not to be covered, because it goes down the same sloppy
lane as removing dotfiles in user homes, which I would expect most
people to argue against removal on package purge.

> Filing this as important as having a piuparts clean archive is a
> release goal since lenny.

 That's a valid approach, though I might argue with whether piuparts
should force this point of view onto packages, thus setting severity to
minor.  Policy doesn't clearly state that, and from what I understand,
userdata is crucial and IMHO something highly different to configuration
files which are removed on package purges.

 If you insist I though could add a
"rmdir /var/lib/gitolite 2>/dev/null || true" into the postrm, which
would make piuparts but play next to no role for real use cases of the
package when people do fill in data in the debconf questions.

 Sorry for late response, we discussed this on IRC back in march
already but this never made it into the BTS, so here it is.

 Enjoy,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los      |
Fühlst du dich hilflos, geh raus und hilf, los    | Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los    |



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to