On Tue, Aug 9, 2011 at 8:45 PM, Aron Xu <happyaron...@gmail.com> wrote:
> reassign 579893 src:conky
> retitle 579893 src:conky: enable more features in conky packages
> thanks
>
> I think in conky-std, there are too few features enabled, however
> conky-all is in contrib, this gives main users no chance to have more
> features usable (curl, rss, etc). So I reassign and retitle this
> report to a more general one. There are two ways of enabling more
> features for "main" users, by adding a new binary, or changing
> conky-std. This is up to the maintainer's decision, so I haven't
> created the patch.
>
> Comments?
>

I agree (in fact, I was planning to address this issue in a future
upload). Looking at conky's popcon scores, there are relatively few
conky-std users compared to conky-all (61 vs 2102), so instead of
adding yet another conky binary, I'd rather just enable more features
in conky-std, i.e. the ones that are more commonly used. Features that
have very specific uses, or are only useful to a small subset of conky
users (e.g. nvidia support, eve support, IBM/lenovo support, etc.)
won't go in conky-std.

> As for conky-all's more player support, I have created the patch to
> enable xmms2 and audacious, no BMPx support because it's not in
> Debian. This patch also enable -O3 by default (the old one was -O2).
> It builds fine on latest amd64 sid.
>
>
>
> diff -ru debian-old/changelog debian/changelog
> --- debian-old/changelog        2011-08-10 03:38:12.362932245 +0000
> +++ debian/changelog    2011-08-10 03:36:52.778933721 +0000
> @@ -1,3 +1,10 @@
> +conky (1.8.1-3) UNRELEASED; urgency=low
> +
> +  * Enable xmms2 and audacious support.
> +  * Use -O3 by default.
> +
> + -- Aron Xu <a...@debian.org>  Wed, 10 Aug 2011 11:33:09 +0800
> +
>  conky (1.8.1-2) unstable; urgency=low
>
>   * Add build dependency on libxnvctrl-dev | nvidia-settings to keep Conky
> diff -ru debian-old/control debian/control
> --- debian-old/control  2011-08-10 03:38:12.362932245 +0000
> +++ debian/control      2011-08-10 03:37:25.018928935 +0000
> @@ -10,7 +10,7 @@
>               libiw-dev [linux-any], libasound2-dev [linux-any],
>               libkvm-dev [kfreebsd-any], libdevstat-dev [kfreebsd-any],
>               libxnvctrl-dev [i386 amd64] | nvidia-settings [i386 amd64],
> -              libncurses5-dev
> +              libncurses5-dev, libxmmsclient-dev, audacious-dev
>  Homepage: http://conky.sourceforge.net/
>  Standards-Version: 3.9.2
>  Vcs-Svn: svn://svn.debian.org/svn/collab-maint/deb-maint/conky/trunk
> Only in debian/patches: fix-xmms2.patch
> diff -ru debian-old/rules debian/rules
> --- debian-old/rules    2011-08-10 03:38:12.362932245 +0000
> +++ debian/rules        2011-08-10 03:38:02.918931878 +0000
> @@ -17,7 +17,7 @@
>  ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
>        CFLAGS += -O0
>  else
> -       CFLAGS += -O2
> +       CFLAGS += -O3
>  endif
>
>  ifeq ($(DEB_HOST_ARCH_OS),linux)
> @@ -70,7 +70,7 @@
>        ../configure $(COMMON_CONFIGURE_FLAGS) \
>         --enable-imlib2 --enable-rss --enable-weather-xoap \
>        --enable-eve --enable-lua-cairo --enable-lua-imlib2 \
> -       --disable-static --enable-argb \
> +       --disable-static --enable-argb --enable-xmms2 --enable-audacious \
>        $(LINUX_CONF_ARGS_ALL) $(ENABLE_NVIDIA)
>
>        touch $@
>
>
> --
> Regards,
> Aron Xu
>
>
>

Thanks for the patch! :)

- Vincent



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to