tags 633756 + upstream
thanks

Hi Regid

2011/7/13 Regid Ichira <regi...@yahoo.com>

> Source: nut
> Version: 2.6.1-1
> Severity: normal
> Tags: patch
>
> bestfcom.c:263:17: warning: variable 'time' set but not used
> [-Wunused-but-set-variable]
> bestfcom.c:263:8: warning: variable 'date' set but not used
> [-Wunused-but-set-variable]
>
>  I don't use this driver.
>
>  The code block in line 139 has other time\|date variables usage.
> I couldn't see where those variables are defined.  There is a comment
> that the author was declined to waste time on their usage.  The
> beginning of the driver states about the derivation process of this
> driver from other drivers.
>

bestfcom is part of NUT legacy drivers, that are still provided, though may
be not used anymore.
anyway, it can still be useful, and it doesn't harm to distribute a few moer
Kbs.

that being said, I've just applied your patch upstream (r3132).

cheers,
Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/

Reply via email to