Source: zynaddsubfx
Version: 2.4.0-1.1
Severity: important
Tags: patch
fluid 1.3.x, which is currently available in experimental and which I
plan to upload to unstable in a few days, generates somewhat different
output from 1.1.x. Most of the differences are purely formal, such
that fluid 1.3.x output is generally compatible with FLTK 1.1
development environments and vice versa. One change, however, affects
zynaddsubfx: per http://www.fltk.org/str.php?L2259, fluid no longer
produces (empty) implementations for totally empty functions in .fl
files, of which zynaddsubfx has a few: BankProcess_::process,
BankProcess_::~BankProcess, PSlider::PSlider, PartUI_::showparameters,
PartUI_::~PartUI_, PresetsUI_::refresh, and PresetsUI_::~PresetsUI_.
You can keep this behavior change from affecting those functions by
adding comments to their bodies. The attached patches (revised
versions of 05_partui.patch and 06_bankui.patch and a new
09_fluid_1.3.patch, which you're welcome to split if you prefer) do
so; could you please apply them, or let me know if you'd agree to an
NMU?
Thanks!
Index: zynaddsubfx-2.4.0/src/UI/PartUI.fl
===================================================================
--- zynaddsubfx-2.4.0.orig/src/UI/PartUI.fl 2011-07-10 11:57:12.000000000 -0400
+++ zynaddsubfx-2.4.0/src/UI/PartUI.fl 2011-07-10 12:05:38.000000000 -0400
@@ -85,7 +85,15 @@
class PartUI_ {} {
Function {showparameters(int kititem,int engine)} {return_type virtual
- } {}
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
+ Function {~PartUI_()} {return_type virtual
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
}
class PartKitItem {: {public Fl_Group}
Index: zynaddsubfx-2.4.0/src/UI/BankUI.fl
===================================================================
--- zynaddsubfx-2.4.0.orig/src/UI/BankUI.fl 2011-07-10 11:57:12.000000000 -0400
+++ zynaddsubfx-2.4.0/src/UI/BankUI.fl 2011-07-10 12:02:57.000000000 -0400
@@ -32,9 +32,17 @@
class BankProcess_ {} {
Function {process()} {open return_type {virtual void}
- } {}
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
decl {Bank *bank;} {public
}
+ Function {~BankProcess_()} {return_type virtual
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
}
class BankSlot {open : {public Fl_Button,BankProcess_}
Index: zynaddsubfx-2.4.0/src/UI/OscilGenUI.fl
===================================================================
--- zynaddsubfx-2.4.0.orig/src/UI/OscilGenUI.fl 2011-07-10 12:07:11.000000000 -0400
+++ zynaddsubfx-2.4.0/src/UI/OscilGenUI.fl 2011-07-10 12:08:06.000000000 -0400
@@ -129,7 +129,11 @@
class PSlider {: {public Fl_Slider}
} {
- Function {PSlider(int x,int y, int w, int h, const char *label=0):Fl_Slider(x,y,w,h,label)} {} {}
+ Function {PSlider(int x,int y, int w, int h, const char *label=0):Fl_Slider(x,y,w,h,label)} {
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
Function {handle(int event)} {return_type int
} {
code {int X=x(),Y=y(),W=w(),H=h();
Index: zynaddsubfx-2.4.0/src/UI/PresetsUI.fl
===================================================================
--- zynaddsubfx-2.4.0.orig/src/UI/PresetsUI.fl 2011-07-10 12:07:21.000000000 -0400
+++ zynaddsubfx-2.4.0/src/UI/PresetsUI.fl 2011-07-10 12:08:49.000000000 -0400
@@ -16,9 +16,15 @@
class PresetsUI_ {} {
Function {refresh()} {open return_type {virtual void}
- } {}
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
Function {~PresetsUI_()} {open return_type virtual
- } {}
+ } {
+ comment {This body intentionally left blank.} {in_source not_in_header
+ }
+ }
}
class PresetsUI {} {
