Hi, I disapprove of using 'signed int' here since 'int' isn't always a consistent size. Either int32_t (if you want a 2GB limit) or ssize_t (if you want anything which will fit into RAM) is what you want.
Aside from that these look reasonable; but I'm not going to commit them to the central bsdiff repo (aka. usr.bin/bsdiff in the FreeBSD src tree) because there's bigger issues I need to work on and I don't want to muck around with minor changes like this when I have a complete rewrite pending. But you can consider these changes "blessed" if that has any meaning for debian. On 07/04/11 01:38, Jari Aalto wrote: > forwarded 632585 Colin Percival (upstream) <cperc...@daemonology.net> > thanks > > 2011-07-03 22:04 Sebastian Andrzej Siewior <sebast...@breakpoint.cc>: > | Package: bsdiff > | Version: 4.3-10 > | Severity: wishlist > | Tags: patch > | > | bsdiff requires 17x the size of the old file in the initial phase which > | is something. This two patches try push it down to 8x. The limitation is > | that max old file size is 2GiB - 1. A diff of file of that size requires > | with patches 16GiB of extra memory (without 32GiB). > | Please find the patches attached including a proper description. > > Hi Colin, > > Would you take a look at these patches and include them in original > sources: > > http://bugs.debian.org/632585 > > Thanks, > Jari -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
