-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 06/30/2011 11:17 AM, Raphael Hertzog wrote:
> On Thu, 30 Jun 2011, Stéphane Graber wrote:
>> if ($generate{keep}) { - my $target =
>> "$DPKG/info/$pack.md5sums"; - copy $sums, $target -
>> or die
>> "$self: can't copy sums to $target ($!)\n"; + @sumfiles =
>> glob("$DPKG/info/$pack.md5sums $DPKG/info/$pack:*.md5sums"); +
>> foreach(@sumfiles) { + copy $sums, $_ +
>> or die "$self: can't
>> copy sums to $_ ($!)\n"; + }
>
> This looks entirely wrong. debsums generate a md5sums when the
> package doesn't provide a md5sums files... so the glob can't return
> anything.
>
> And it's this part that I suggested to get rid of entirely, because
> you're not qualified to know whether it should be "$p.md5sums or
> "$p:$arch.md5sums". Ideally you should store those in a debsums
> specific directory and use "$p:$arch" unconditionnaly.
>
> Cheers,
Oops. I must admit having just done some simple replace in the code and
not having looked that closely to what it actually does.
I agree that generating .md5sums file is really bad and will completely
break the whole concept of having them in the first place.
I'll update the patch to never do the copy if any .md5sums file exist
for the package (so it behaves similarly as the old code) but I also
agree that debsums shouldn't do it in /var/lib/dpkg/info and should do
it somewhere else. Though I'm not the upstream for it (nor want to be)
so I won't be doing that change myself.
Thanks for pointing that mistake out.
- --
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCgAGBQJODFG2AAoJEMY4l01keS1nFf8QALJ7GPhKBhJVoe0l54EJ+/Im
50Yg4Njm61cs9ERGLVBN29HEFnPSiKnjifhxwwGExl+g4mB1XCAKvCqzLP6OizO2
KdkBDcHFaEhKdGyTfnnUjBwixLXQ/oBtkvqg0vitAL8gGmcmFpCvQWrTPs+JWV1X
kh1hMXwYXT5fcPbcmYlTrq4TdfxwBeb0XySxHWXdNycmzi4tyEbVPx6fvTCeGkru
TUHvL4zy+Z8bo6cPmgkTKrOmT/I1T/MkGzuvRPJaFO9/d2Jk9QsoPOLB3+NkBSox
lSDCtVt2lBRCTg0XdQe64ONcrafHIh0Y1gCosE0Ow3kwFHlBj1/6pH5m7nB9W43l
BjIwVwUIvKUGelwf7BtDbl730K5sOmB+S40JmJ1l3EOiA2TwBaIuRhlBDmD1TkXX
USXkpt9Qm/XVq/05mooYTZq8Mh2j7UhJ8hipEA6mDw6jxpwlJBLDpbIbOOgpI5Ga
RUPqidVboGeaOwPmZNx4ubpC0ObUTzVurlinbzqSzpYTI3M5IfZ670STugUg0Rep
1n0whCaTgB0IH9Nko74O79MA0mtSa4dtJeJfdQWGGZNqkIqhGxpFR5COlMPq5TJz
GKnhAveQoSVhR8vZa/OF+v6+CrS5YJ793YK6I3YJvsgBBGdrGOInJRdEBDXWz2Cp
n63QwNqTo2B6Snp6wiaj
=lzZ4
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
