On 06/26/2011 10:00 AM, Holger Levsen wrote:
Hi Scott,

On Sonntag, 26. Juni 2011, Scott Schaefer wrote:
Um ... This is probably (?) due to addition of new states in packagesdb
module.
I think so too, I assume its a little fix in piuparts-report.py

I will try to setup and test here, but I expect it would be much easier
if I had the log
file output from piuparts-reports (and piuparts-analyze ?).
I've bounced the last log to you but its basically useless....

Setting it up is rather easy, run the slave once, then run piuparts-report.


cheers,
        Holger

Argh !!

The problem (at least the biggest problem -- all of the "state" names displaying as "missing") is not related to 526045 at all. Rather it is a problem with patch for 523950, which causes html_protect() to return ' -- i.e. single-quote character as its result.

Attached patch fixes it.

I will investigate your note re "So the circular-depends moved to "dependency-cannot-be-tested", which is only half right.." later or sometime tomorrow.




--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -422,11 +422,11 @@
 
 
 def html_protect(vstr):
-    vstr = "&".join(str.split("&"))
-    vstr = "&lt;".join(str.split("<"))
-    vstr = "&gt;".join(str.split(">"))
-    vstr = "&#34;".join(str.split('"'))
-    vstr = "&#39;".join(str.split("'"))
+    vstr = "&amp;".join(vstr.split("&"))
+    vstr = "&lt;".join(vstr.split("<"))
+    vstr = "&gt;".join(vstr.split(">"))
+    vstr = "&#34;".join(vstr.split('"'))
+    vstr = "&#39;".join(vstr.split("'"))
     return vstr
 
 

Reply via email to