Hi,

Thanks for taking the time to write a bug report.

On 23 June 2011 at 12:06, NIIBE Yutaka wrote:
| Package: dieharder
| Version: 2.28.1-3
| Severity: minor
| 
| I found an issue of random number generator "uvag".
| 
| --- libdieharder/rng_uvag.c~  2008-09-08 21:37:19.000000000 +0900
| +++ libdieharder/rng_uvag.c   2011-06-23 12:03:27.225908700 +0900
| @@ -138,11 +138,11 @@
|    * single seed, unsigned long int in type.  Alex requires a key 
|    * string 256 characters long (that is, 64 uints long).  We therefore
|    * have to bootstrap off of an existing, deterministic GSL RNG to fill
| -  * the seed string from a single permitted seed.  Note that type 12 is
| +  * the seed string from a single permitted seed.  Note that type 13 is
|    * the mt19937 generator, basically one of the best in the world -- not
|    * that it matters.
|    */
| - seed_rng = gsl_rng_alloc(types[12]);
| + seed_rng = gsl_rng_alloc(types[13]);
|   seed_seed = s;
|   gsl_rng_set(seed_rng,seed_seed);
|   random_max = gsl_rng_max(seed_rng);
| 
| Also, I checked dieharder-3.31.1~20110601 (sid).  While code is fixed,
| comment still says "type 12". 

Yes, in SVN right now I see 

 /*
  * OK, here we have to modify Alex's algorithm.  The GSL requires a
  * single seed, unsigned long int in type.  Alex requires a key string
  * 256 characters long (that is, 64 uints long).  We therefore have to
  * bootstrap off of an existing, deterministic GSL RNG to fill the seed
  * string from a single permitted seed.  Note that type 12 is the
  * mt19937_1999 generator, basically one of the best in the world -- not
  * that it matters.
  */
 seed_rng = gsl_rng_alloc(dh_rng_types[14]);

so it is now '14' within a lookup table.  The documentation comment may
warrant updating, the code seems fine.

In any event, the version 2.28.1-3 is seriously outdated, consider focusing
on the 3.31.1 prerelease '3.31.1~20110601' now in Debian testing and
unstable.

Regards,  Dirk
 
| -- System Information:
| Debian Release: 6.0.1
|   APT prefers stable-updates
|   APT policy: (500, 'stable-updates'), (500, 'stable')
| Architecture: i386 (i686)
| 
| Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
| Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
| Shell: /bin/sh linked to /bin/dash
| 
| Versions of packages dieharder depends on:
| ii  libc6                        2.11.2-10   Embedded GNU C Library: Shared 
lib
| ii  libdieharder2                2.28.1-3    Random-number generator test 
libra
| ii  libgsl0ldbl                  1.14+dfsg-1 GNU Scientific Library (GSL) -- 
li
| 
| dieharder recommends no packages.
| 
| dieharder suggests no packages.
| 
| -- no debconf information
| 
| 

-- 
Gauss once played himself in a zero-sum game and won $50.
                      -- #11 at http://www.gaussfacts.com



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to