Hi Courtney,

On Fri, Jun 17, 2011 at 01:51:48PM -0500, Courtney Bane wrote:
> Package: git-buildpackage
> Version: 0.5.25
> Severity: wishlist
> File: /usr/bin/gbp-create-remote-repo
> Tags: patch
> 
> gbp-create-remote-repo doesn't support remote URL patterns of the form
> "ssh://<host>/~/<path>", even though git does. I've attached a patch
> that adds support for this (by removing "/~/" from the beginning of the
> path if it's found there).

Patch looks great. But according to the got-clone manpage git also
supports ~user expansion:

ssh://[user@]host.xz[:port]/~[user]/path/to/repo.git/ 

Could you handle that case too?
Cheers,
 -- Guido

> 
> -- System Information:
> Debian Release: wheezy/sid
>   APT prefers testing
>   APT policy: (900, 'testing'), (800, 'unstable'), (700, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.38-2-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages git-buildpackage depends on:
> ii  devscripts                   2.11.0      scripts to make the life of a 
> Debi
> ii  git [git-core]               1:1.7.5.3-1 fast, scalable, distributed 
> revisi
> ii  python                       2.6.6-14    interactive high-level 
> object-orie
> ii  python-dateutil              1.4.1-3     powerful extensions to the 
> standar
> ii  python-support               1.0.13      automated rebuilding support for 
> P
> 
> Versions of packages git-buildpackage recommends:
> ii  cowbuilder                    0.62+nmu2  pbuilder running on cowdancer
> ii  pristine-tar                  1.13       regenerate pristine tarballs
> 
> Versions of packages git-buildpackage suggests:
> pn  git-load-dirs                 <none>     (no description available)
> pn  python-notify                 <none>     (no description available)
> 
> -- no debconf information

> diff --git a/gbp-create-remote-repo b/gbp-create-remote-repo
> index e7cce9b..2b9ccb4 100755
> --- a/gbp-create-remote-repo
> +++ b/gbp-create-remote-repo
> @@ -55,9 +55,13 @@ def parse_remote(remote_url, name, pkg):
>          raise GbpError, "Remote URL must use ssh protocol."
>      if not '%(pkg)s' in remote_url and not remote_url.endswith(".git"):
>          raise GbpError, "Remote URL needs to contain either a repository 
> name or '%(pkg)s'"
> +    if frags.path.startswith("/~/"):
> +        path = frags.path[3:]
> +    else:
> +        path = frags.path
>      remote = { 'pkg' : pkg,
>                 'url' : remote_url % { 'pkg': pkg },
> -               'dir' : frags.path % { 'pkg': pkg },
> +               'dir' : path % { 'pkg': pkg },
>                 'host': frags.netloc,
>                 'name': name}
>      return remote




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to