Hi Daniel, Daniel Baumann wrote:
> this is an updated patch attached for 1.7.6~rc1-1. Thanks for an update. > as i don't intend to send an updated patch for each and every revision, I doubt that merging with a new Debian revision would have changed the patch at all, actually. > also, please let me know if there's anything missing for the actual > addition of the sysvinit stuff Sure. Looking back over the review at Bug#422139, I see: - /etc/init.d/git-daemon is not handled as a configuration file, which violates policy ยง10.7.3. I don't think that's a fundamental problem, but I am not willing to merge this unless it's at least documented so people do not get bitten by trying to make customizations. - some small style nitpicks. If you care deeply about these things, I'm fine with leaving them alone, obviously. - the initscript uses start-stop-daemon --make-pidfile instead of using the git daemon's own --pid-file support. I don't understand why the patch does this; daemons that know how to make their own pid files are not what --make-pidfile is for. - the initscript tries to kill git-daemon's children based on the executable used. That's dangerous if someone is running another instance of git-daemon not managed by the initscript on another port, and it's totally unnecessary --- git-daemon doesn't have any children using the git-daemon executable, since the children serving connections are git-upload-pack, git-upload-archive, etc. Hope that helps. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
