On Wed, 15 Jun 2011 17:49:50 +0200 David Kuehling <dvdkh...@gmx.de> wrote:
> > Neil Williams <codeh...@debian.org> writes: > > On Wed, 18 May 2011 15:09:44 +0200 > > David Kuehling <dvdkh...@gmx.de> wrote: > > > Think about this more carefully. The situation is that multistrap is > > stateless and something can have happened which means that the run > > when the packages are actually downloaded failed at a later stage > > (e.g. in the hooks or setupscript) and then got fixed. So a later run > > of multistrap still needs to go through the status file (because the > > .debs have been unpacked and deleted) to check if some source packages > > still need to be downloaded. apt-get install will check the status > > file and report that it the packages are already at the newest > > version, without downloading anything, so the list has to come from > > somewhere else. i.e. the list of downloaded debs is untrustworthy and > > must be regarded as incomplete. > > Ok, if this is the case, then why do we have to collect source packages > (dsclist) at 3 places in multistrap.conf . Won't it be sufficient to > just do it once, when parsing the status file? Error handling is the main reason. Unpacking might fail, the archives might be the only source of data. Could you have a look at the current SVN revision and let me know how that matches your tests? > >> The patch also fixes another bug, not yet reported: multistrap could > >> have fetched source packages versions that differ from the binary > >> package versions. > > > That is more about differences in aptsources and debootstrap lines > > than anything to do with specifying the version. I don't think your > > patch actually works here. apt-get source will get the latest, just as > > apt-get install will get the latest. What changes is whether the call > > is made when aptsources are active or when bootstrap sources are > > active. It needs to be bootstrap sources. I'd need to have a real > > example of where apt-get install will download a different version to > > what apt-get source will download for the same sources - that would be > > a bug in apt, not multistrap. (Multistrap creates deb-src lines for > > each source specified, so the versions are expected to be the same > > from deb to deb-src or else there are problems with the archive.) > > That's exactly the problem: inconsistent versions in the archive or > archive updates while multistrap runs. That sounds like a broken archive. I haven't implemented the versioned source call - I remain unconvinced that a valid archive would cause the download of a source package of a different version to the binary package. -- Neil Williams ============= http://www.linux.codehelp.co.uk/
pgpYd785Swt9j.pgp
Description: PGP signature
