On 06/13/2011 06:10 AM, Kurt Roeckx wrote:
On Fri, May 06, 2011 at 08:35:57AM -0400, Scott Schaefer wrote:
See attached. Prints "completion" message only on successful return.
Also fixes bug which prevents executing -newreq-nodes option, and
includes newer options in usage message.
Can you also check the CA.sh script for the same problems?
Kurt
I will be glad to submit patch for CA.sh, since, on quick review, it
indeed has same two problems as CA.pl; i.e.
1) It prints "success" messages, even on failure of underlying SSL
command(s), and
2) The usage message in lacking the newer, added valid arguments,
This will probably require 24-48 hours, since I have travel commitment
tomorrow.
OTOH, my assertion that my original patch for CA.pl 'fixes bug which
prevents executing -newreq-nodes option' is WRONG. I badly misread that
code in order to conclude what I did; i.e. the original code does
execute both -newreq and -newreq-nodes options correctly.
Note the patch still correctly executes both options, and both did
incorrectly print "success" message even on failure of underlying SSL
command. For this reason, I would prefer to leave the patch intact, and
simply change the second part of the description to only "Also includes
newer options in usage message". If you prefer, I can submit revised
patch file that does not re-order the testing of command-args vs
patterns /^-newreq$/ and/^-newreq-nodes$/.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
