Package: python-django
Version: 1.3-2.1
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch

Hi folks,

The python-django package currently build-depends on
locales-all | language-pack-en-base in order to get an en_US.UTF-8 locale
for use in the test suite.  This works, but as you can see the locales-all
package isn't available in Ubuntu so making the build-dependency line
portable means using various alternatives.

I think it would be better to simply generate the needed locale as part of
the package build and point to it with the $LOCPATH env var.  This is
certainly more efficient than downloading a 4MB .deb for the use of a single
locale.

Attached please find a patch that implements this build-time locale
generation.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru python-django-1.3/debian/control python-django-1.3/debian/control
--- python-django-1.3/debian/control	2011-05-02 13:58:59.000000000 -0700
+++ python-django-1.3/debian/control	2011-06-13 11:09:41.000000000 -0700
@@ -4,7 +4,7 @@
 Maintainer: Chris Lamb <la...@debian.org>
 Uploaders: Debian Python Modules Team <python-modules-t...@lists.alioth.debian.org>, Raphaƫl Hertzog <hert...@debian.org>
 Standards-Version: 3.9.2
-Build-Depends: debhelper (>= 7.0.50), python-support, python (>= 2.5) | python-sqlite, locales-all | language-pack-en-base
+Build-Depends: debhelper (>= 7.0.50), python-support, python (>= 2.5) | python-sqlite
 Build-Depends-Indep: python-sphinx, libjs-jquery
 Homepage: http://www.djangoproject.com/
 Vcs-Svn: svn://svn.debian.org/python-modules/packages/python-django/trunk/
diff -Nru python-django-1.3/debian/rules python-django-1.3/debian/rules
--- python-django-1.3/debian/rules	2011-05-02 13:48:05.000000000 -0700
+++ python-django-1.3/debian/rules	2011-06-13 13:24:18.000000000 -0700
@@ -32,7 +32,10 @@
 
 override_dh_auto_test:
 	touch tests/__init__.py
-	LC_ALL=en_US.utf8 PYTHONPATH=. tests/runtests.py --settings=tests.test_sqlite --verbosity=2
+	mkdir -p tmp-locales
+	localedef -i /usr/share/i18n/locales/en_US -c -f UTF-8 -A /usr/share/locale/locale.alias tmp-locales/en_US.UTF-8
+	LOCPATH=$(CURDIR)/tmp-locales LC_ALL=en_US.UTF-8 PYTHONPATH=. tests/runtests.py --settings=tests.test_sqlite --verbosity=2
+	rm -rf tmp-locales
 
 override_dh_clean:
 	# backup~ is used in tests

Reply via email to