Package: tcpick
Version: 0.2.1-1
Severity: important
Tags: patch

On the ppc C compiler, char is an unsigned data type. This means that
no variable of type char can ever compare equal to the int value -1. gcc
tries to warn you about this when you compile tcpick, by saying:

args.c:195: warning: comparison is always true due to limited range of data type

tcpick therefore never makes it past the getopt loop. The following
patch fixes the problem.

diff -ru tcpick-0.2.1/src/args.c tcpick-0.2.1.pac/src/args.c
--- tcpick-0.2.1/src/args.c     2005-09-09 01:21:07.000000000 -0500
+++ tcpick-0.2.1.pac/src/args.c 2005-09-09 01:51:35.000000000 -0500
@@ -149,7 +149,7 @@
 void
 parse_args(int argc, char ** argv)
 {
-       char opt;
+       int opt;
 
 #ifdef HAVE_GETOPT_LONG
        static struct option long_options[]=


-- System Information:
Debian Release: 3.1
Architecture: powerpc (ppc)
Kernel: Linux 2.6.11-powerpc
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages tcpick depends on:
ii  libc6                       2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libpcap0.8                  0.8.3-5      System interface for user-level pa

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to