Package: zabbix
Version: 1:1.8.5-1
Tags: patch
Severity: important
Hi,
It was noticed when 1.8.5 was merged in Ubuntu with the LDAP linker bug
patched (the same patch as in Debian Bug #556770), that the patches do
not get properly applied by dpkg-buildpackage, when it is not building
the source package (due to dpkg-source not been run between
'debian/rules clean' & 'debian/rules build').
This caused, a second FTBFS, but also, the realization that both in
Debian & Ubuntu, patches applied to the source, may not have been
present in the binary builds (potentially causing regressions).
Below is the 'bzr diff' of debian/rules that changes the calling
location of the 'prepare' section from 'extract' (where it would never
be run) to 'build' where it will be run once only, prior to any
extracting/copying of the source for individual builds.
(Note, I haven't selected Serious severity, even though it likely is, as
it seems builds to date for Debian have worked and nobody has complained
of any regressions)
- Nigel
=== modified file 'debian/rules'
--- debian/rules 2011-02-21 22:59:41 +0000
+++ debian/rules 2011-06-10 10:42:36 +0000
@@ -107,7 +107,7 @@
# Copy the source directory (without the 'debian' directory) to other
locations
# to configure and compile the sources there for each database flavor.
-extract: prepare $(foreach s,$(VARIANTS),extract-$(s)-stamp)
+extract: $(foreach s,$(VARIANTS),extract-$(s)-stamp)
extract-%-stamp:
@echo "--------------------------"
@echo "Copying source directory to $(BUILDDIR)-$(*) for building the
$(*) variant there"
@@ -127,7 +127,7 @@
touch $@
# Compile the flavors
-build: $(foreach s,$(VARIANTS),build-$(s)-stamp)
+build: prepare $(foreach s,$(VARIANTS),build-$(s)-stamp)
build-%-stamp: configure-%-stamp
@echo "--------------------------"
@echo "Compiling the $(*) flavor in $(BUILDDIR)-$(*)"
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
