Package: calamaris
Version: 2.99.4.0-13
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

With perl 5.12 I get the following warning:

/etc/cron.daily/calamaris:
defined(%hash) is deprecated at /usr/bin/calamaris line 2357.
        (Maybe you should just omit the defined()?)

More info from `perldoc perldiag':

       defined(%hash) is deprecated
           (D deprecated) defined() is not usually useful on hashes because it 
checks for an undefined
           scalar value.  If you want to see if the hash is empty, just use "if 
(%hash) { # not empty }"
           for example.

And indeed, the following change seems to work:


#v+
- --- /usr/bin/calamaris.orig     2011-05-20 21:56:47.000000000 +0200
+++ /usr/bin/calamaris  2011-05-20 21:57:15.000000000 +0200
@@ -2354,7 +2354,7 @@
   $report_index = 11;
   @format = ref($formats[$report_index]) ?
     @{$formats[$report_index]} : ( 32, 9, '%', '%', 'off', 8, '%', '%', 'off' 
);
- -  if ( defined(%tcp_content) ) {
+  if ( %tcp_content ) {
     outstart($report_index);
     if ( $tcp == 0 ) {
       outline( $report_index, '', 'no matching requests' );
#v-


Cheers,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJN1sfoAAoJELs6aAGGSaoGyFgP/3Bah2K3tAHthY7Sgvafttvk
W1cUrp6jxAjfWExop3TPReS3VhX1o5FB5+4UTICbV6dOPiTFmdkPxOjqiwsFruMh
sU9MUFvHAd/zjOinPaI9OTVSOTrYtn4pTH058exoUSyYzAMzbhT8pQ64bzcXgso5
8FqUQiiunntdbZZaVVuzphwheR8gamaDoWBAdYbzMNTzsLwT8lL0C99D6uYpYikH
1baJu7wfwG1eT10Y5d1lyHipqMRwVs2yjNQJl4OTt+I+gwGIuT8TfX5rlA13L6lq
f3vH7NM9X224Yn/3DrIc7xMcNyaROFcvHd9nfRBYTf0IqzDcgPL3t2mazq5bE5Om
YEX9KXCrXWUDmFZBYu/RzF5nF/mShDssVTDwska5z1swsBkImE1oJM1cnfu2MXs/
2FPfVZRVp93bwCYlMHXyEK4QiAfLJK66ev5Ci2jo+xWzHH9t4gNPwXHsM3WIlA54
FJDFRag1PxNEJhU8PuvcHes+O6ztuDnydQIDm5E0EltmllWWjgb5AZnbplQu/rs+
fzh0AWX9YqZg+1sfhLFMfub/AdZk4LjuxgALc8vfkdPTZXKZC1nWFtyQ6fRuIMyP
tC5q68SczVf/uajS3bL/xY5lIZbzQOqdhU/ZjyA0y1tsiUaVReyXAnWEZElkFfly
6HX53Vexa8n3GD19Yksb
=kGVO
-----END PGP SIGNATURE-----



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to