Hi, and thanks for the patch.
Le vendredi 20 mai 2011 à 19:10 +0800, YunQiang Su a écrit :
> diff -ruN debian-2.30.0-1/changelog debian-3.0.2-1/changelog
> --- debian-2.30.0-1/changelog 2011-05-20 00:20:01.000000000 +0800
> +++ debian-3.0.2-1/changelog 2011-05-17 11:13:54.000000000 +0800
> @@ -1,3 +1,21 @@
> +gedit-plugins (3.0.2-1) experimental; urgency=low
> +
> + * New upstream stable release.(3.0.2 released)
Please document the other changes. At least mention the
build-dependencies have changed, and this is far from being the only
one.
> +gedit-plugins (3.0.0-0) natty; urgency=low
Please drop the Ubuntu changelog entries, unless they correspond to a
real Ubuntu upload with relevant changes.
> diff -ruN debian-2.30.0-1/control debian-3.0.2-1/control
> --- debian-2.30.0-1/control 2011-05-20 00:20:01.000000000 +0800
> +++ debian-3.0.2-1/control 2011-05-17 11:14:42.000000000 +0800
Please modify control.in instead of control.
> @@ -1,25 +1,18 @@
> Source: gedit-plugins
> Section: gnome
> Priority: optional
> Maintainer: Loic Minier <l...@dooz.org>
> Uploaders: Debian GNOME Maintainers
> <pkg-gnome-maintain...@lists.alioth.debian.org>, Josselin Mouette
> <j...@debian.org>, Sebastian Dröge <sl...@debian.org>
> -Build-Depends: cdbs,
> - debhelper (>= 5),
> +Build-Depends: debhelper (>= 7.0.50~),
> intltool (>= 0.35.0),
This should be 0.40.0.
> + libglib2.0-dev (>= 2.26.0),
> + libgtk-3-dev (>= 3.0.0),
> + libgtksourceview-3.0-dev (>= 2.91.9),
This one should be 3.0.0.
> + libpeas-dev (>= 0.7.3),
> + gedit-dev (>= 2.91.11),
This one too is 3.0.0.
> python-support (>= 0.7.1)
You are also missing python-dbus.
> Depends: ${shlibs:Depends},
> ${misc:Depends},
> ${python:Depends},
> - gedit (>= 2.29.3),
> + gedit (>= 2.91.11),
BTW gedit is missing a Breaks on gedit-plugins < 2.91. This is unrelated
to these changes, though.
> + gir1.2-gucharmap-2.90,
> + gir1.2-peas-1.0,
> + gir1.2-vte-2.90
You are missing the following modules: Glib, Gtk, Gdk, Pango, GtkSource.
> --- debian-2.30.0-1/rules 2011-05-20 00:20:01.000000000 +0800
> +++ debian-3.0.2-1/rules 2011-04-03 20:15:19.000000000 +0800
> +%:
> + dh $@
If you want to switch to dh (and I’m not convinced it is appropriate),
you need to use --with gnome, and don’t forget the build-dependency on
the appropriate gnome-pkg-tools.
> -DEB_CONFIGURE_EXTRA_FLAGS += --with-plugins=all --enable-python
You still need to pass this.
> -clean::
> - plugins_desc_script="/^ @PLUGINS_DESCRIPTION@\$$/ c \\
> $$(find . -iname \*.desktop.in.in | while read f; do cat $$f | awk -f
> debian/desktop2description.awk; done | sed 's/.*/ &\\/'; echo " ")";
> \
> - sed \
> - -e "s#@GNOME_TEAM@#$(UPLOADERS)#g" \
> - -e "$$plugins_desc_script" \
> - debian/control.in > debian/control
You still need to do this, dh won’t magically do it for you.
Cheers,
--
.''`. Josselin Mouette
: :' :
`. `'
`-
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
