retitle 607346 git upload-pack: can deadlock when serving shallow clone
retitle 626212 git fetch-pack: please work around server-side shallow clone hang
# difficult
severity 626212 wishlist
tags 626212 + upstream
quit

Hi Mats,

Mats Erik Andersson wrote:

> The result is very disappointing. This is the complete test run,
> using manual commanding. The version 1.7.5.1 is available for i386,
> but not for kfreebsd-amd64, so only the former can be investigated.
>
>   * Success:   git clone --depth 2 git://git.sv.gnu.org/gnulib.git
>
>   * Failure:   git clone --depth 1 ..../gnulib.git
>     Aborted

Yep, I can reproduce it now.  Tracing with GIT_TRACE_PACKET=1 shows
that common ancestor negotiation proceeds as expected and then the
server goes quiet.

A quick search finds [1], which reminds me that the problem fixed by
v1.7.5.1~4^2 (upload-pack: start pack-objects before async rev-list,
2011-04-06) was a server-side problem.  Ah, that makes sense.

So why does using an older client seem to trigger it less easily?
Well, on this machine v1.7.2.3 has no problem triggering it; I think
you were just lucky.  I can't think of an easy way to automatically
work around it on the client side off-hand --- better to fix the
servers suffering from that deadlock.

Still it's possible there is some nice workaround I'm overlooking, so
I'm leaving the bug open for now to give a chance to think about it.

Thanks again for a clear report, and hope that helps.

Regards,
Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/172042



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to