Hi Niall
Thanks for the answers. Now I think I know enough to file a bug upstream.
Thanks again.
On Wed, May 04, 2011 at 05:05:21PM +0100, Niall Donegan wrote:
> On 03/05/11 19:44, Ola Lundqvist wrote:
> > First I would like to ask about the purpose of this. Why do you want
> > to remove that interface? Is it because of some real problem or is this
> > more of a cosmetic nature to get it removed from the list when you
> > issue ifconfig?
>
> A few years working with Virtuozzo has given me an irrational fear of
> venet! Seriously though, when setting up a system using just veth
> devices, I don't see the point in having it appear there if it's not needed.
Ok. Thanks then I know.
> >> +if [ -f /etc/default/vz ] ; then
> >> + . /etc/default/vz
> >> +fi
> >
> > I assume this file should be installed by the Debian package as well
> > then, right?
>
> I was going to say yes, however as you've pointed out further down, if
> the above is put under the variables already there, there isn't as much
> a need of adding it to the package. If people like me need to override
> the defaults, we can just create /etc/default/vz manually.
>
> I'm not sure what packaging best practices are though.
Ok, thanks.
> >
> >> if [ "${MODULES_DISABLED}" != "yes" ]; then
> >> PRELOAD_MODULES="af_packet"
> >> @@ -59,7 +51,10 @@
> >> MODULES_OTHER="vzcompat ${CPT_MODULES}"
> >> VNET_MODULES="vznetdev vznet"
> >> VETH_MODULES="vzethdev"
> >> - NET_MODULES="${VNET_MODULES} ${VETH_MODULES}"
> >> + NET_MODULES="${VETH_MODULES}"
> >> + if [ -n "${VZDEV}" ]; then
> >> + NET_MODULES="${NET_MODULES} ${VNET_MODULES}"
> >> + fi
> >
> > Why do you want to remove the module?
>
> If it's not needed why load it?
That is another way to put it.
> print_result
> >> +
> >> + if [ -n "$VZDEV" ]; then
> >> + if ip addr list | grep -q "venet0:.*UP" 2>/dev/null; then
> >> + __echo "Bringing down interface $VZDEV: "
> >> + ip link set $VZDEV down
> >> + print_result
> >> + fi
> >
> > Should this really be done? What happens if you have it set
> > to something first when you start vz, and then you comment it out
> > and stop vz later? I do not see why this can hurt in any way.
>
> True. I was actually just working from
> http://wiki.openvz.org/Disable_venet_interface but on second reading, it
> does seem redundant.
Ok.
> > As a sidenote I wonder why it search for venet0 hardcoded when the name
> > is actually configurable...
>
> A bug to raise with upstream?
I'll send them a bug report when I issue a bug for this one.
// Ola
>
> --
> The virus contained in this message was not detected.
>
> http://niall.donegan.tel
>
>
>
--
--------------------- Ola Lundqvist ---------------------------
/ o...@debian.org Annebergsslingan 37 \
| o...@inguza.com 654 65 KARLSTAD |
| http://inguza.com/ +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
