On Tue, Sep 06, 2005 at 01:48:14AM -0400, Eric Dorland <[EMAIL PROTECTED]> wrote: > Thanks for looking at this. Since Firefox 1.5 is right around the > corner and will presumably have these fixes, I don't know if there's > any applying it at this point.
Moreover, they might already been fixed in 1.0.99+deerpark-alpha2-2... Not tagging since i'm not quite sure, but i will mark this bug fixed in 1.4.99+1.5beta1-1 which i will upload to experimental as soon as it's released. Cheers, Mike > * Kevin Buhr ([EMAIL PROTECTED]) wrote: > > This has now been (mostly) fixed on the upstream trunk (see Mozilla > > bugs 251492 and 244955), but it won't be fixed on the upstream Aviary > > 1.0.x branch. > > > > I've made a GTK2-only backport of the fix (which includes patches from > > Mozilla bugs 238854, 251492, and possibly others---direct comparison > > with trunk versions was part of the backport process), so this should > > close bug #257430 (and its many merged pals). It doesn't fix the > > #310098 selection sub-bug, though: selected text is still black on > > dark blue with the Simple theme. > > > > The attached main patch applies cleanly to 1.0.4-2sarge1, and I've > > tested it with all the themes available with the Sarge gnome-themes > > and gnome-themes-extra packages installed, at least as far as menus > > go. The remaining issues are: > > > > 1. The menu bar item whose menu is currently dropped down uses > > the same background colour as for the currently selected > > menu item. In some themes, like Simple, these two > > backgrounds are different for native GTK apps. > > > > 2. Icons for checkbox menu items are sometimes clipped. For > > example, in the Glider theme, the checkmarks are so badly > > clipped they look like they're backwards. > > > > 3. The little submenu arrowhead is always white for a selected > > menu item, regardless of theme. > > > > Note that all three of these issues remain in the current upstream > > trunk. Also note that, even though with the Simple theme, checkbox > > and radio buttons in menu items "disappear" when the menu item is > > selected, this is a problem with the theme: menus in native GTK > > applications exhibit the same problem. > > > > Finally, note that I haven't been able to test this patch with Debian > > version 1.0.6-2 (though it has been tested with the upstream 1.0.6 > > source) because I haven't gotten the Sid Debian package to build on my > > Sarge box. The base patch will still apply cleanly, but you'll also > > need to apply the extra fixup patch before it'll compile. I suspect > > it'll work fine after that, but someone will need to do at least some > > basic testing to be sure. > > > > -- > Eric Dorland <[EMAIL PROTECTED]> > ICQ: #61138586, Jabber: [EMAIL PROTECTED] > 1024D/16D970C6 097C 4861 9934 27A0 8E1C 2B0A 61E9 8ECF 16D9 70C6 > > -----BEGIN GEEK CODE BLOCK----- > Version: 3.12 > GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ > O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ > G e h! r- y+ > ------END GEEK CODE BLOCK------ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
