Package: debhelper
Version: 8.1.3
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello,

I found that dh_installgsettings fails to detect that a package of mine,
latexila, uses gsettings. Consequently it does not install the proper
dependency in ${misc:Depends} as it is supposed to do.

This is because of an improper use of find:
    find $gsettings_schemas_dir -type f -name \\*.xml -o -name \\*.override 
-printf '%P '
See the -o? Well, the -printf only applies to its second operand, which is
clearly not what is wanted. I suggest to add parentheses to correct that:
    find $gsettings_schemas_dir -type f \\( -name \\*.xml -o -name \\*.override 
\\) -printf '%P '

The attached patch applies this correction. For your information this is
blocking my bug #620388 (well, I can work around it by writing the dependency
explicitely, of course, but I can wait).

Regards,

- -- 
Tanguy Ortolo

- -- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debhelper depends on:
ii  binutils               2.21.0.20110327-3 The GNU assembler, linker and bina
ii  dpkg-dev               1.16.0.2          Debian package development tools
ii  file                   5.04-5+b1         Determines file type using "magic"
ii  html2text              1.3.2a-15         advanced HTML to text converter
ii  man-db                 2.5.9-4           on-line manual pager
ii  perl                   5.10.1-19         Larry Wall's Practical Extraction 
ii  perl-base              5.10.1-19         minimal Perl system
ii  po-debconf             1.0.16+nmu1       tool for managing templates file t

debhelper recommends no packages.

Versions of packages debhelper suggests:
pn  dh-make                       <none>     (no description available)

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCgAGBQJNuI7rAAoJEOryzVHFAGgZin4P+gIin9pZIXjxA5eGtapRdQeI
89gEjztqXwazmQms+0aE0TeoYm3iDvnVrUUqircxoEqM936YryT26fkmcGTMsTiA
U+KXHJKYtARbe3PerXVsrEINpWzpwosu0vibZMabhUjQDxBtUiXqInL+hlEPbOGP
1IpT7flvn6RZHZL/6LrcHsruLQYuidC0KxIn8J6LQaebbqV6LpHJ25ngTLGxUsFu
IfPnpda3Cvh4IX550bosEUf6lH2YyzNZTjcoJscxmH/uOFMwDSfUBQRCHEnPRRGV
/FrzkK5hl5v2b69JM866oclF85HLJIgJK16b/JZuukb6/EvmxD/WKiBBVdTJpYAm
0VrB7FpwQefdcK4jVGDy8s4JQnbvXtvcgZ5U3aMqU6yvGiD3VT2y6cubWJhuOBiW
Nlhj6H9ZwHW4mvmK5eGsVtxPpEcGJgXXpUIi+G3jHCix0Yoep/vGz24zpv45TN0c
UvSWrSvZMJS5P+6W9nmr+IYUSa2yCXNz4x7kTdEGn6BN7SpYSRjAqr44R55MP/aL
7InqsmiejOSB3v3mgeOYtg49Rr4vgxqA9NFMFYDSqGedlBIpsYkCRCJ3E4k9JnFb
Dw1lnqzYsfjXF1e+QcF1XQC4KmkwzDngZId1gaAdJFRlFxayOZUfPfVzbWRNyxhN
mQLuwuMevmxHi4Ht8mit
=8Eie
-----END PGP SIGNATURE-----
--- dh_installgsettings 2011-04-27 23:32:02.080508162 +0200
+++ /usr/bin/dh_installgsettings        2011-04-27 23:35:32.689812857 +0200
@@ -72,7 +72,7 @@
 
        if (-d "$gsettings_schemas_dir") {
                # Get a list of the schemas
-               my $schemas = `find $gsettings_schemas_dir -type f -name 
\\*.xml -o -name \\*.override -printf '%P '`;
+               my $schemas = `find $gsettings_schemas_dir -type f \\( -name 
\\*.xml -o -name \\*.override \\) -printf '%P '`;
                if ($schemas ne '') {
                        addsubstvar($package, "misc:Depends", 
"dconf-gsettings-backend | gsettings-backend");
                }

Reply via email to