Hi Joey
On Sun, Apr 24, 2011 at 03:44:32PM -0400, Joey Hess wrote:
> Salvatore Bonaccorso wrote:
> > ikiwiki-hosting-web has libdigest-sha1-perl in Depends field. However
> > greping over the source, I find only:
> >
> > $ grep -R 'Digest::SHA' *
> > IkiWiki/Customer.pm: eval q{use Digest::SHA};
> > IkiWiki/Customer.pm: return Digest::SHA::sha1_hex($openid);
> >
> > Thus, can the dependency on libdigest-sha1-perl be removed? As
> > furthermore Digest::SHA is in perl core already provided in Lenny, no
> > further dependencies should be added.
>
> In the perl core? Am I missing something?
>
> joey@gnu:~>perl -e 'use Digest::SHA1 q(sha1_hex); print sha1_hex("foo")'
> 0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33joey@gnu:~>
> joey@gnu:~>sudo dpkg --force-depends --purge libdigest-sha1-perl
> ...
> joey@gnu:~>perl -le 'use Digest::SHA1 q(sha1_hex); print sha1_hex("foo")'
> Can't locate Digest/SHA1.pm in @INC (@INC contains: /etc/perl
> /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5
> /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10
> /usr/local/lib/site_perl .) at -e line 1.
> BEGIN failed--compilation aborted at -e line 1.Thanks for the fast reply! :-) Well not Digest::SHA1 but Digest::SHA: $ dpkg -S Digest/SHA.pm libdigest-sha-perl: /usr/lib/perl5/Digest/SHA.pm perl: /usr/lib/perl/5.10.0/Digest/SHA.pm So, if I do not miss something, IkiWiki/Customer.pm already uses Digest::SHA, but has a depencency on libdigest-sha1-perl (providing Digest::SHA1). Thus: ikiwiki-hosting-perl uses already Digest::SHA (no changes needed here) and the dependency on libdigest-sha1-perl could be dropped? Am I right? Background: Digest::SHA provides nearly the same functionality of Digest::SHA1 (except sha1_transform). See [1] for details or [2]. [1] http://bugs.debian.org/594273 [2] http://bugs.debian.org/591091 (your bugreport ;-)) Bests Salvatore
signature.asc
Description: Digital signature
