unmerge 581428
reassign 581428 src:parole 0.2.0.2-3
severity 581428 wishlist
retitle 581428 parole: configure script does not accept CONFIG_SHELL=/bin/dash
tags 581428 + upstream patch
quit
Hi Yves-Alexis,
Yves-Alexis Perez wrote:
> On jeu., 2010-05-13 at 22:35 +0000, Gerrit Pape wrote:
>> The problematic line in the script
>> is 21295
>> BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-"\${libdir}/mozilla/plugins"}"
>>
>> You can workaround this problem with this patch to parole's ./configure
>
> Well, configure files are autogenerated, so that means the problem lies
> before that. Does that mean autotools generate incorrect configure
> files, or does that means that particular one is buggy?
It is from configure.ac. Patch below.
> Or does that
> mean dash is definitely doing the wrong thing?
I think it's a dash bug. As a separate but related question, it's
possible the configure script is doing the wrong thing, too. The
Austin standards revision group considered this and decided:
The standard is unclear on this issue, and no conformance
distinction can be made between alternative implementations based
on this. This is being referred to the sponsor.
The next revision of the standard (Issue 8) will probably disallow
this construct, using the proposed wording:
If any unescaped double-quote characters occur within the
string, other than in embedded command substitutions, the
behavior is unspecified.
See <http://austingroupbugs.net/view.php?id=221> for details.
> It seems we have some other packages which will FTBFS with errors in
> configure too, and I guess a fully archive rebuild would exhibit quite
> some failures because of that.
http://bugs.debian.org/582952
> I'm not finger pointing, but is the dash
> change really legit?
Sounds like (useful) finger pointing to me. ;-)
Since the configure script is making use of a murky part of POSIX, I
still consider it an (upstream) bug. Here's a quick patch. Running
autoconf and rebuilding with it (with dash from experimental as
/bin/sh) gives
[...]
| CCLD parole
| /usr/bin/ld: parole-button.o: undefined reference to symbol 'XGrabKey'
| /usr/bin/ld: note: 'XGrabKey' is defined in DSO /usr/lib64/libX11.so.6
| so try adding it to the linker command line
| /usr/lib64/libX11.so.6: could not read symbols: Invalid operation
| collect2: ld returned 1 exit status
which looks like progress to me.
Thoughts welcome, as always.
configure.ac | 2 +-
debian/rules | 3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 79814b5..29dd50e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -211,7 +211,7 @@ AC_MSG_CHECKING([whether to build the browser plugin])
AM_CONDITIONAL([ENABLE_BROWSER_PLUGIN], [test x"$ac_browser_plugin" = x"yes"])
AC_MSG_RESULT([$ac_browser_plugin])
if test x"$ac_browser_plugin" = x"yes"; then
- BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-"\${libdir}/mozilla/plugins"}"
+ : ${BROWSER_PLUGIN_DIR:="\$libdir/mozilla/plugins"}
AC_ARG_VAR([BROWSER_PLUGIN_DIR],[Where to install the browser plugin])
AC_DEFINE(BUILD_BROWSER_PLUGIN, 1, [whether to build with browser plugin
support])
fi
diff --git a/debian/rules b/debian/rules
index 5665df5..a890608 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,9 +1,6 @@
#!/usr/bin/make -f
#LDFLAGS += -Wl,-z,defs -Wl,--as-needed
-export SHELL=/bin/bash
-export CONFIG_SHELL=/bin/bash
-
%:
dh $@
--
1.7.5.rc3
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
