On Sun, Apr 17, 2011 at 04:12:01PM +0200, Bastien ROUCARIES wrote:
> On Sun, Apr 17, 2011 at 3:14 PM, Ron <r...@debian.org> wrote:
> >
> > Hi Bastien,
> >
> > On Tue, Apr 05, 2011 at 03:48:09PM +0200, Bastien ROUCARIES wrote:
> >> Package: gitpkg
> >> Version: 0.18
> >> Severity: normal
> >>
> >> Create a package with version 2.3.0~r29173-1 and try to export it using
> >> quilt patch export will not work.
> >>
> >> Git disalllow ~ in tag or branch. Therefore gitpkg should transform ~ to _
> >> internally before creating patch
> >
> > Sorry for the slow reply, we've been pondering this one for a few days,
> > because it's not quite so simple as just transforming ~ to _, since there
> > there are a number of illegal constructs, and there is no actual standard
> > for remapping them that we know everyone is using.
> >
> > One of the aims of gitpkg is that it should be able to extract a working
> > source package from pretty much any sane git repository, without having
> > to arrange that repo in some specific form beforehand. So it's fairly
> > important that we can cater for people who chose a different mapping too.
> >
> > The hooks, by nature, can imply additional constraints, but I'd still like
> > to keep this as flexible as possible where we can.
> >
> > What it looks like we'll probably do for now is use the sanitise_git_ref
> > function (currently only in the git-debimport script), and then get the
> > quilt hook to export {DEB,UPSTREAM}_REF mangled with it (which basically
> > does what you are asking for, replaces all chains of illegals with a
> > single '_').
>
> According to debian standard only [1-9][A-Z[a-z][+~] are legal for
> debian version. so remapping ~ to _ is reasonable .
The upstream version is allowed to contain ':' and both could legally
contain '..', then there could be things like ':~' and combinations of
these things that might not be unique after mangling. Some people might
reasonably have mapped those all to different characters.
Hopefully most of these should be rare (or non-existent) but we need to
make sure we aren't painted into a corner if they do crop up.
Anyhow, new packages are in the tubes now. Thanks for spotting this!
Best,
Ron
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
