Petr Salinger writes: >>> your package no longer builds on kfreebsd-*: >>> | [ 87%] Building CXX object >>> applications/present3D/CMakeFiles/application_present3D.dir/Cluster.o >>> | cd >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/build/osg/applications/present3D >>> && /usr/bin/c++ -g -O2 -Wall -Wparentheses -Wno-long-long -Wno-import >>> -pedantic -Wreturn-type -Wmissing-braces -Wunknown-pragmas -Wunused >>> -fpermissive -O3 -DNDEBUG >>> -I/build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/include >>> >>> -I/build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/build/osg/include >>> -o CMakeFiles/application_present3D.dir/Cluster.o -c >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/applications/present3D/Cluster.cpp >>> | >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/applications/present3D/Cluster.cpp:56:6: >>> error: #error Teach me how to build on this system >>> | >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/applications/present3D/Cluster.cpp: >>> In member function 'void Receiver::sync()': >>> | >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/applications/present3D/Cluster.cpp:369:64: >>> warning: invalid conversion from 'int*' to 'socklen_t*' >>> | >>> /build/buildd-openscenegraph_2.9.11-1-kfreebsd-amd64-jXKFmU/openscenegraph-2.9.11/OpenSceneGraph/applications/present3D/Cluster.cpp:374:72: >>> warning: invalid conversion from 'int*' to 'socklen_t*' >>> | make[3]: *** >>> [applications/present3D/CMakeFiles/application_present3D.dir/Cluster.o] >>> Error 1 >>> >>> Full build logs: >>> >>> https://buildd.debian.org/status/package.php?p=openscenegraph&suite=experimental >>> >>> Please get in touch with debian-bsd@ if you need help for porting. >>> >>> KiBi. >> >> Hi, >> >> The problem comes from a list of cascading #ifdef checks that fails >> because __FreeBSD__ is not defined. I wonder if just defining >> __FreeBSD__ in the Makefile is fine > > Please do not do this. > >> or if I must instead patch the >> package to check, for example, if __FreeBSD_kernel__ is defined. > > It depends. The idealr way is not to test OS/libc, but test whether a > header exist (AC_CHECK_HEADER in autoconf), or whether a type > socklen_t > is known from headers. This change have to be performed by upstream. > > In mean time "|| defined(__FreeBSD_kernel__)" or > "|| defined(__GLIBC__)" is the usual way. > > Petr
Thank you very much for the explanation, Petr. I will append "|| defined(__FreeBSD_kernel__)" for now. -- Alberto -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
