Thanks for the patch. It looks mostly ok, but I have a few concerns: * People may have built up high scores in their home directories and might be annoyed to have those disappear. Perhaps it could use the scores in the home directory if present, otherwise the shared one? Unfortunately we can't import these on upgrade: iterating home directories may be expensive (many users), impossible (encrypted home dirs), and/or unsafe (maliciously crafted score files).
* The patch exposes an existing bug: exit(1) happens if the score file can't be written. Oops! This will now happen if the user is not in the "games" group (quite likely). Should instead complain and/or fall back to the home directory. * The above two points then mean that the only users using the shared file will be those who were already in the games group before first run. It would be nice if everyone else got some sort of hint that shared scores were now possible, somehow. Nothing that gets in the way and needs acknowledgement, but perhaps a line in the UI near the high scores? "See /usr/share/doc/crack-attack/README.scores"... not sure. Thanks, -- Chris Boyle http://chris.boyle.name/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
