Package: dump
Version: 0.4b43-1

I'm trying to believe this is all the fault of #588675 and dump is
blameless, but I'm uncertain. The problem is pretty straightforward, when
the root filesystem is listed in /etc/mtab|/proc/mounts as "/dev/root",
the output for the -w option for the root filesystem will be:

$ dump -w
Dump these file systems:
  /dev/root     (     /) Last dump: never
$ 

No matter what /etc/fstab and /var/lib/dumpdates say about the actual
device.

I'm guessing you're doing a stat() of /dev/root as that is listed by
/etc/mtab, recording the st_rdev field, and then when you scan /etc/fstab
you find out the st_rdev value for the real device matches and thus
ignore the duplicate. Problem of course is the real device is used in
/var/lib/dumpdates and so the above is always listed.

In addition to scanning /etc/fstab first (or if later entries override
earlier ones, second); might I suggest `dump` really should be indexing
/var/lib/dumpdates by UUID instead? This avoids problems if device names
change, such as if controllers are added or moves. This would also notice
if everything was restored to a new filesystem.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         e...@gremlin.m5p.com PGP F6B23DE0         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
2477\___\_|_/DC21 03A0 5D61 985B <-PGP-> F2BE 6526 ABD2 F6B2\_|_/___/3DE0





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to