tags 619332 + fixed-upstream pending thanks On Wed, Mar 23, 2011 at 01:03:00AM +0200, Modestas Vainius wrote: > you added --keep-session: > > + A new option, --keep-session, has been added (Closes: #609658). > This prevents the automatic removal of session-managed snapshot > chroots. Previously, snapshots would not be deleted if purging > of the build directory or build dependencies was disabled, but > this was not always desirable, hence it is now configurable > separately > > While I agree with general idea that end_session should be configurable > individually, you actually removed the feature to keep the session only if > build fails. Obviously I have no way of knowing if build is going to fail in > advance so --keep-session as boolean command line option is mostly useless > for > me. > > Please allow to set --keep-session via both command line and sbuildrc with > the > same set of values and behaviour that $purge_build_* options accept.
I've replaced --keep-session with --purge-session=(always|successful|never). This allows it to take the same values as the other --purge options. I have also allowed $end_session to take the same values rather than a single boolean value. Is this OK? Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
