Source: angband
Version: 1:3.1.2v2-2
Severity: important
Justification: potential ftbfs
Tags: upstream patch
Hi,
Trying to build angband from
<git://git.debian.org/git/collab-maint/angband.git>, I noticed
that configure.ac contains
# Only change bindir if it's the configure-supplied default, which handily
doesn't expand exec_prefix
if test "x$bindir" == "x\${exec_prefix}/bin"; then
[...]
This causes dash from experimental to write
checking for make silent include syntax... gnu
./configure: 4285: test: x${exec_prefix}/bin: unexpected operator
make[2]: Entering directory `/tmp/angband'
and "test" returns status 2, which I don't think is what was intended.
Eventually the build fails with
strip: '/tmp/angband/debian/angband/usr/games/angband': No such file
Using = in place of == fixes it. Thoughts?
-- 8< --
Subject: configure: avoid unportable test "foo" == "bar" construct
dash and FreeBSD ash do not support the == operator to test for
equality. Luckily = works okay.
Without this patch, the affected shells place angband in /usr/bin
instead of /usr/games as they ought to. This probably wasn't
noticeable until recently because the configure script used to
reject these shells and fall back to something else because they
lacked $LINENO support.
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index ff6f0e2..b2e126d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -93,7 +93,7 @@ if test "x$with_private_dirs" != "x"; then
fi
# Only change bindir if it's the configure-supplied default, which handily
doesn't expand exec_prefix
-if test "x$bindir" == "x\${exec_prefix}/bin"; then
+if test "x$bindir" = "x\${exec_prefix}/bin"; then
bindir=${exec_prefix}/games
fi
--
1.7.4.1
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
