On Fri, Feb 25, 2011 at 08:42:40PM +0100, Christian Kastner wrote:
> When repacking ZIP files, because of the way uscan invokes tar, the
> current directory '.' (dot) is always included in the resulting tar
> archive.

We do that to ensure that everything unpacked from the zip file is
included in the resulting tar file (e.g., a hidden file at the top-level
of the unpacked tree).

> Unpacking such an archive has the side effect of tar attempting to
> change the permissions of the cwd, as easily reproduced by unpacking
> such a tarball from within the /tmp directory. Regular users get an
> error, root has the permissions of /tmp changed.
> 
> Another minor issue is that the user and group name are leaked into the
> archive, instead of using the neutral 'root'.

These are issues, though.  Instead of your suggested solution for the
first one, I think using tar's --transform argument to remove the
leading ./ may be cleaner.  The fix for the second issue looks good.

-- 
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <james...@debian.org>

Attachment: signature.asc
Description: Digital signature

Reply via email to