Package: dirvish
Version: 1.2.1-1.1
Severity: normal
Tags: patch

When having a line in the vault config like:

tree: /root/backupmnt/ /

It behaves like

tree: /root/backupmnt/

The alias to "/" is ignored. This means that a file at the root of the
transfer named test, ends up in the index named

/root/backupmnt/test

Whereas one would expect the index file to contain this name as

/test

because of the alias option.

Attached patch fixes that behaviour. Currently, dirvish does the
following things:

- remove trailing slashes
- if "alias" is empty, set it equal to "path", the first argument to the
  tree option.

By reversing the order of these two operations, the behaviour ought to
be as expected for all cases, including "alias to root", if you ask me.

Thanks,

Peter.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing'), (100, 'unstable'), (100, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dirvish depends on:
ii  libtime-modules-perl         2006.0814-2 Various Perl modules for time/date
ii  libtime-period-perl          1.20-8      Perl library for testing if a time
ii  perl                         5.10.1-17   Larry Wall's Practical Extraction 
ii  perl-modules                 5.10.1-17   Core Perl modules
ii  rsync                        3.0.7-2     fast remote file copy program (lik

Versions of packages dirvish recommends:
pn  ssh                           <none>     (no description available)

dirvish suggests no packages.

-- Configuration Files:
/etc/cron.d/dirvish changed [not included]

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/sbin/dirvish (from dirvish package)
--- dirvish.pl  2005-02-19 02:07:53.000000000 +0100
+++ dirvish.pl.new      2011-03-19 10:41:21.000000000 +0100
@@ -418,8 +418,8 @@
        or seppuku 228, "ERROR: no source tree defined";
 $srctree =~ s(\\ )( )g;                     #+SIS
 $srctree =~ s(/+$)();
-$aliastree =~ s(/+$)();
 $aliastree ||= $srctree;
+$aliastree =~ s(/+$)();
 
 $destree = join("/", $vault, $image, 'tree');
 $reftree = join('/', $vault, $$Options{Reference}, 'tree');

Reply via email to