On Thu, Mar 10, 2011 at 08:48:35PM +0100, Sean Finney wrote: > Hi Guido, > > On Wed, 2011-03-09 at 22:59 +0100, Guido Günther wrote: > > * I think we can avoid introducing Command.popen by adding ls_tree to the > > Git > > class itself which already has a __git_getoutput class to read the output > > of > > git commands. > > okay, done. > > > * It might make sense to turn GitArchive int Git.archive(format, > > prefix, output, treeish) for readability again extending the Git > > class. > > done. > > > * dump_tree creates a new repo = GitRepository() it might be better to > > pass in the existing one. > > done, also did this with git_archive too. > > I haven't tested all the error vectors that I did with the previous > change, but gave it a quick run through and the shasums on the generated > orig.tar.gz are matching what I uploaded a few days ago, so I think it's > good. > > I just pushed them on top of the current branch for your review. Pushed now. Thanks a lot to both of you! I needed some tweeks for dump_tree but that was about it. Would be great if you could retest current master.
I intend to add some speedups to git_archive and finish the tests before pushing the new release. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
