Thanks Brett for the bug report. Your patch looks simple enough. I wonder though if it's not better to simply escape the whole line so that it is URL safe. I'll test that patch and, if it seems to work and to solve the problem, I'll send this upstream and patch it in Debian.
Regards, Mako <quote who="Brett Wuth" date="Wed, Mar 16, 2011 at 03:37:16PM -0600"> > Package: libwww-mediawiki-client-perl > Version: 0.31-1.1 > Severity: normal > Tags: patch > > > The program chokes when asked to get a wiki page that includes an > ampersand (&) in its name. > > > $ mvs update 'A&W Restaurant.wiki' > Doing update A&W Restaurant.wiki with host: localhost and lang: en > Can't call method "isa" without a package or object reference at /usr/bin/mvs > line 96. > $ > > with the attached patch to pagename_to_url, the operation succeeds. > > ---cut--- > --- Client.pm.orig 2006-07-01 09:55:08.000000000 -0600 > +++ Client.pm 2011-03-16 15:31:24.000000000 -0600 > @@ -1318,6 +1318,10 @@ > ) if $name =~ /.wiki$/; > my $char = $self->space_substitute; > $name =~ s/ /$char/; > + > + # ampersand is escaped in the URL > + $name =~ s/&/%26/; > + > my $lang = $self->language_code; > my $host = $self->host; > $host =~ s/__LANG__/$lang/g; > ---cut--- > > -- System Information: > Debian Release: 5.0.8 > Architecture: i386 (i686) > > Kernel: Linux 2.6.22-14-generic (SMP w/1 CPU core) > Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/bash > > Versions of packages libwww-mediawiki-client-perl depends on: > ii libexception-class-perl 1.24-1 a module that allows you to > declar > ii libvcs-lite-perl 0.08-2 Minimal version control system > ii libwww-perl 5.813-1+lenny2 WWW client/server library for > Perl > ii libxml-libxml-perl 1.66-1+b1 Perl module for using the GNOME > li > ii perl 5.10.0-19lenny3 Larry Wall's Practical > Extraction > > libwww-mediawiki-client-perl recommends no packages. > > libwww-mediawiki-client-perl suggests no packages. > > -- no debconf information > -- Benjamin Mako Hill m...@atdot.cc http://mako.cc/ Creativity can be a social contribution, but only in so far as society is free to use the results. --GNU Manifesto
signature.asc
Description: Digital signature
