Hi Micheal, thanks for the patch. I'll think a bit more about this. Of course, it seems only reasonable to merge it. However, it is a very partial fix for a very specific problem. If, for example, Phil had used TCP syslog instead of UDP syslog, the patch would not have helped. So it is very specific to one input. Providing the same for TCP, I think, is quite more complicated (but I may be wrong).
I understand you point that we should not try to proactively fix things. On the other hand, I wonder how realistic it is that we run into the same situation at all. If it is, and if that really is an issue, then I think we must evaluate the other obvious cases. We can't simply ignore that problem potential if there is a real use case behind it. This is what I am concerned about. Any thoughts? Rainer > -----Original Message----- > From: Michael Biebl [mailto:bi...@debian.org] > Sent: Monday, March 14, 2011 4:14 AM > To: Phil Dibowitz; 617...@bugs.debian.org > Cc: Rainer Gerhards > Subject: Re: Bug#617996: rsyslog: remote syslog messages not logged > > Am 14.03.2011 01:08, schrieb Phil Dibowitz: > > On 03/13/2011 04:15 AM, Michael Biebl wrote: > >> Attached is a very simple (though untested) patch, which imho > doesn't really > >> complicate the code. > >> > >> Phil, could you please try that patch. Compile it using your new > kernel, test > >> rsyslog using your new kernel, the boot the old kernel again and see > if it still > >> works correctly. > > > > Tested, works great, thanks!! > > > > Rainer, in case you decide to merge this patch, here is one with a > proper commit > header which can be applied using git am. > > Cheers, > Michael > > -- > Why is it that all of the instruments seeking intelligent life in the > universe are pointed away from Earth? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
