tags 617720 + pending
thanks

Hi Michael,

[...]
> 
> I propose the following sanity checks for setup-storage:
> * Each mountpoint (except -) should appear at most once
> * Ensure that LVM PVs have mountpoint -
> 
> In such cases setup-storage should exit with a useful error message.
> 

Thanks a lot for those ideas! I've implemented them in 4.0~beta2+experimental61.
In fact, setup-storage already did contain a check_config function that did some
very basic consistency checking, which has now been extended as suggested.
Thanks!!

> (Another problem was that this user had his nfsroot exported with
> root_squash, so pvcreate failed due to not being able to read
> /var/lock/lvm. It would be nice if this error could be detected as well
> and specifically suggested setting no_root_squash if /var/lock/lvm has a
> non-root owner.)
>

Hmm, I'm not sure whether this is really going to fly - obviously there is an
infinite number of potential issues that people could run into and we can't
catch all of them. Even more so, I really wouldn't want to clutter setup-storage
with such checks *UNLESS* pvcreate itself issues some specific error message or
has a distinct exit code. If that is the case, it could easily be added to
setup-storage if someone could just let me know about that (setup-storage does
check exit codes and output of the commands it executes and knows about some
frequently occurring errors).

Best regards,
Michael

Attachment: pgpGovr9Y6sfJ.pgp
Description: PGP signature

Reply via email to